Change runSelectionInActiveTerm effect to warning#351
Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom Jun 6, 2020
Merged
Change runSelectionInActiveTerm effect to warning#351renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken merged 1 commit intoREditorSupport:masterfrom
Conversation
Member
|
LGTM. Please feel free to merge if there's nothing to be added. |
renkun-ken
approved these changes
Jun 1, 2020
renkun-ken
reviewed
Jun 6, 2020
Collaborator
Author
|
@renkun-ken Thank you for testing and reviewing! I will merge. |
Collaborator
Author
|
@renkun-ken And thank you for merging! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #306
What problem did you solve?
Replaces effect of
R: Run Selection/Line in Active Terminalwith warning message, in preparation for its eventual removal.How can I check this pull request?
Use command
R: Run Selection/Line in Active Terminal. Observe code is NOT sent to terminal. Observe warning message 'This command has been removed. Enable setting "Always Use Active Terminal".'