Fix previewDataframe for 2+ letter variables#390
Merged
andycraig merged 1 commit intoREditorSupport:masterfrom Aug 11, 2020
Merged
Fix previewDataframe for 2+ letter variables#390andycraig merged 1 commit intoREditorSupport:masterfrom
andycraig merged 1 commit intoREditorSupport:masterfrom
Conversation
Member
|
LGTM. Feel free to merge. |
Collaborator
Author
|
Thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #389
What problem did you solve?
Command
R: Preview Dataframedoes not work if data frame name is 2+ letters. E.g.,R: Preview Dataframeworks if data frame name isa, but not if data frame name iscars.The reason is that
getWordOrSelection()changed from returning an array of strings to returning a single string, but its use in this function was not updated.How can I check this pull request?
Create a file called
temp.Rcontaining just the textcars. Place cursor oncarsand useR: Preview Dataframe. Observe that preview appears as expected.Change the text to
cars cars. Select BOTH WORDS and useR: Preview Dataframe. Observer the message 'This does not appear to be a dataframe', as expected (because the selection contains a space).