Remove Ctrl + 1, 2, 3, 4, 5 shortcuts#401
Conversation
|
I just removed the shortcuts lines but I should have removed the whole command JSON section. Will update and force push. |
|
Fixed and ready for review. |
renkun-ken
left a comment
There was a problem hiding this comment.
LGTM.
Do we consider this as breaking changes? Users who rely on these shortcuts as defaults will suddenly find that they don't work anymore. We might need strong notice in the changelog.
|
@renkun-ken Yes, We can move the old shortcut to the wiki and put the URL on the CHANGELOG |
|
@andycraig Would you like to update the wiki and changelog as @Ikuyadeu suggests? |
|
@renkun-ken Yep, will do so this weekend. |
|
Unlikely to get to it this weekend after all, but it's on my list. |
|
Done! @Ikuyadeu @renkun-ken Could one of you check the update to the CHANGELOG? If you are happy with it, please merge. Thanks! |
|
It looks perfect! Thanks! |
|
@renkun-ken @andycraig Great works! Thank you! @renkun-ken And, congratulations on your MVP Award! |
Fixes #368
What problem did you solve?
Shortcuts
Ctrl + 1, 2, 3, 4, 5overlap with default VS Code shortcuts. This PR removes these shortcuts. The commands are unchanged.How can I check this pull request?
Run command
Preferences: Open Keyboard Shortcutsand search forCtrl + 1. Observe that only command isworkbench.action.focusFirstEditorGroup.