Skip to content

Remove Ctrl + 1, 2, 3, 4, 5 shortcuts#401

Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom
andycraig:issue-368
Sep 2, 2020
Merged

Remove Ctrl + 1, 2, 3, 4, 5 shortcuts#401
renkun-ken merged 2 commits intoREditorSupport:masterfrom
andycraig:issue-368

Conversation

@andycraig
Copy link
Copy Markdown
Collaborator

Fixes #368

What problem did you solve?

Shortcuts Ctrl + 1, 2, 3, 4, 5 overlap with default VS Code shortcuts. This PR removes these shortcuts. The commands are unchanged.

How can I check this pull request?

Run command Preferences: Open Keyboard Shortcuts and search for Ctrl + 1. Observe that only command is workbench.action.focusFirstEditorGroup.

@andycraig andycraig changed the title Remove Ctrl + 1, 2, 3, 4, 5 shortcuts WIP Remove Ctrl + 1, 2, 3, 4, 5 shortcuts Aug 19, 2020
@andycraig
Copy link
Copy Markdown
Collaborator Author

I just removed the shortcuts lines but I should have removed the whole command JSON section. Will update and force push.

@andycraig
Copy link
Copy Markdown
Collaborator Author

Fixed and ready for review.

@andycraig andycraig changed the title WIP Remove Ctrl + 1, 2, 3, 4, 5 shortcuts Remove Ctrl + 1, 2, 3, 4, 5 shortcuts Aug 19, 2020
Copy link
Copy Markdown
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we consider this as breaking changes? Users who rely on these shortcuts as defaults will suddenly find that they don't work anymore. We might need strong notice in the changelog.

@Ikuyadeu
Copy link
Copy Markdown
Member

@renkun-ken Yes, We can move the old shortcut to the wiki and put the URL on the CHANGELOG

@renkun-ken
Copy link
Copy Markdown
Member

renkun-ken commented Aug 28, 2020

@andycraig Would you like to update the wiki and changelog as @Ikuyadeu suggests?

@andycraig
Copy link
Copy Markdown
Collaborator Author

@renkun-ken Yep, will do so this weekend.

@andycraig
Copy link
Copy Markdown
Collaborator Author

Unlikely to get to it this weekend after all, but it's on my list.

@andycraig
Copy link
Copy Markdown
Collaborator Author

Done! @Ikuyadeu @renkun-ken Could one of you check the update to the CHANGELOG? If you are happy with it, please merge.

Thanks!

@renkun-ken
Copy link
Copy Markdown
Member

It looks perfect! Thanks!

@renkun-ken renkun-ken merged commit c5c11af into REditorSupport:master Sep 2, 2020
@Ikuyadeu
Copy link
Copy Markdown
Member

Ikuyadeu commented Sep 3, 2020

@renkun-ken @andycraig Great works! Thank you!

@renkun-ken And, congratulations on your MVP Award!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove or warn about cmd + 1 shortcut defaults

3 participants