Fix so rTerm is undefined when deleting terminal#403
Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom Aug 23, 2020
Merged
Fix so rTerm is undefined when deleting terminal#403renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken merged 1 commit intoREditorSupport:masterfrom
Conversation
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #402
What problem did you solve?
If session watcher is on but
R: Always Use Active Terminalis off, closing an R terminal created by vscode-R does not undefinerTerm. This means that future commands that should create a new R terminal instead do nothing.How can I check this pull request?
R: Session WatcherR: Always Use Active Terminaltemp.Rwith contentx <- 1R: Run Selection/LineR Interactiveterminal is created and line is sent to terminalR Interactiveby clicking on the terminal trashcan icon. Terminal should now be1: cmd(if on Windows)R: Run Selection/LineWith PR
Terminal
R Interactiveis created and line is sent to terminal.Before PR
Nothing happens.
Notes
I came up with this after putting a breakpoint on the original
rTerm = undefinedline and discovering that it was never reached.