Improve handling html help#427
Conversation
|
@MilesMcBain Do you think if this makes sense to resolve #426? @magic-lantern Would you like to try this one and see if it works to resolve #380 ? |
|
@renkun-ken - I'd love to test and see if this resolves the other issue. What do I need to do for testing - such as clone/build/something else? |
|
@magic-lantern You could download the vsix at https://github.com/Ikuyadeu/vscode-R/actions/runs/321213341 and install in under remote development and see if |
|
Changes look good. I was just wondering about testing myself. I'll install this vsix in my docker container. |
|
It seems that it already worked in docker before the change? It works now as well anyhow. I tested over ssh and it also works now, as per screen shot. The style sheet issue is interesting, the help appeared normal in the Docker case. I had also expected VSCode would need me to confirm port forwarding with some kind of dialog? I didn't see it. |
|
@MilesMcBain Not sure if port mapping under remote via containers works differently from via ssh. It's good as long as it works anyway. Thanks for testing! |
|
@MilesMcBain Sounds like you've looked at the code and were happy with the changes, and have also tested it and found it works? If so, please feel free to mark this PR as approved. (There should be a 'Review' button at the top of the 'Files changed' tab.) |
|
@renkun-ken - Thanks for the help on how to test. I have tested in my current VSCode environment and this update does fix #380 for me. |

What problem did you solve?
Addresses #426, #380
Some users may prefer other ways to read help documentation (e.g.
textand setoptions(help_type="text")in.Rprofile). Using session watcher will no longer override that preference if specified.This PR also adds printing the browsing url before sending browser request to session watcher so that vscode will capture the port in url and perform auto port forwarding under remote develoment. This is a walk around of microsoft/vscode#102449.
(If you do not have screenshot) How can I check this pull request?
Regarding
options(help_type=)options(help_type="text")in~/.Rprofile.?get, the documentation will show up in the terminal instead of a new WebView tab..Rprofileand restart an R session?getand the documentation will show up in a new WebView tab instead of text.Regarding printing URL in browser request:
?getBrowsing <URL>message will show up in the terminal output and auto port forwarding should be triggered.