fix and enhance navigateToFile#430
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Oct 27, 2020
Merged
Conversation
- fix big where positions were being converted twice - add 'reveal' so that position or seleciton is scrolled to in file
renkun-ken
reviewed
Oct 26, 2020
renkun-ken
approved these changes
Oct 26, 2020
Member
renkun-ken
left a comment
renkun-ken
left a comment
There was a problem hiding this comment.
Tested and it works well.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
(If you do not have screenshot) How can I check this pull request?
check that in an attached VSCode R session
rstudioapi::navigateToFile(file, row, colum)opens a text editor to path infileand scrolls to show the cursor at position line =row, column =column. Does not need to be an .R file.For example in the VSCode-R project, with an attached R session,
rstudioapi::navigateToFile("src/rstudioapi.ts", 154, 23)should navigate to the Typescript definition fornavigateToFile.