Add terminal information to chooseTerminal error#447
Merged
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom Nov 16, 2020
Merged
Add terminal information to chooseTerminal error#447Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
Conversation
andycraig
changed the title
andycraig
changed the title
Collaborator
Author
|
Ready for review. |
Ikuyadeu
reviewed
Nov 16, 2020
Member
|
Good! It can be merged. |
Collaborator
Author
|
@Ikuyadeu Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
This is related to #385. I can't reproduce the error, so this PR adds more information to the error message, which users can pass on to us.
Screenshot
I can't reproduce the error, so I made this screenshot by copy-pasting the message code to the top of
chooseTerminal().EDIT: Updated the image.
How can I check this pull request?
I don't have instructions for how to reproduce the error, so I think review will have to be code review only, without testing.