Skip to content

Fix typo in help panel path config#457

Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:bugFix
Nov 22, 2020
Merged

Fix typo in help panel path config#457
renkun-ken merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:bugFix

Conversation

@ManuelHentschel
Copy link
Copy Markdown
Member

#454 #455
Fix typo in accessing config entry r.helpPanel.rpath which caused this setting to be ignored.

@ManuelHentschel ManuelHentschel changed the title Fix type in help panel path config Fix typo in help panel path config Nov 22, 2020
@renkun-ken
Copy link
Copy Markdown
Member

Thanks for the fix! It looks like r.helpPanel.rpath does not default to r.rterm.* but getRpath(), which is inconsistent with the description

Defaults to r.rterm.XXX.

Could you confirm that and update the description if it is the case?

@ManuelHentschel
Copy link
Copy Markdown
Member Author

Thanks for the fix! It looks like r.helpPanel.rpath does not default to r.rterm.* but getRpath(), which is inconsistent with the description

Defaults to r.rterm.XXX.

Could you confirm that and update the description if it is the case?

I used that description, since getRpath() will read the corresponding r.rterm.xxx setting first and only be different from accessing the setting directly if it needs to fall back to a different method

@ManuelHentschel
Copy link
Copy Markdown
Member Author

But I'd suggest skipping the r.rterm.xxx fallback and instead use the fallback methods used in getRpath() directly

@renkun-ken
Copy link
Copy Markdown
Member

renkun-ken commented Nov 22, 2020

Yes, that's exactly what I meant. Forgot that getRpath reads config first.

Copy link
Copy Markdown
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested on macOS and it works nicely now.

@renkun-ken renkun-ken merged commit 82e22f3 into REditorSupport:master Nov 22, 2020
@ManuelHentschel ManuelHentschel deleted the bugFix branch November 28, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants