Fix whole of style (Extends #361)

[Ikuyadeu]

What problem did you solve?

#361 was too large to solve all issues.
This PR only apply the easy fix, and I gave up that fixing all rule violation once, especially for the any value warnings.
I want to fix remained violations in another issue, after merge this.

I confirmed that fixing current new functions source code readability is very hard work.
This PR can be the first step to keeping this extension maintainability

Next TODO:

• Refactor any values it can be object

  • extension.ts
  • rHelpPanel.ts
  • RHelpProviderBuiltin.ts
  • rstudioapi.ts
  • session.ts
  • test/suite/index.ts

• Simplify extension.ts

  • Remove goto label it can be simple for statement
  • Move Rmd functions to another file

[Ikuyadeu]

Could someone review this?
I think this change has no impact on the code behavior, but I want to someones check.

[renkun-ken]

Here on my side, eslint complains about the use of the deprecated assert.equal:

Should we do anything about it?

[Ikuyadeu]

Thank you for your point.
Maybe it is not eslint, it is a typescript function alert.
But It's good timing, I'll fix it to assert.strictEqual

[renkun-ken]

I go through the changes and all look good. Tested on macOS and everything works well.

[ManuelHentschel]

Is there a performance benefit from importing each item explicitly or is this just a stylistic choice?

[Ikuyadeu]

It is not alerted by ESLint and performance issue, but it is useful to refactoring based on the vscode API.
In this case, we can confirm rHelpPanel.ts manage the Webview API related function.
If someone implements a related function in another file, we should combine that in this file or implement super-class

[Ikuyadeu]

I merge this, thank you @renkun-ken and @ManuelHentschel for your comments.