Implement R workspace viewer#476
Implement R workspace viewer#476renkun-ken merged 17 commits intoREditorSupport:masterfrom ElianHugh:master
Conversation
Removed superflous code, changed import, changed formatting
|
One thing to notice is that when an R session exits, the |
ManuelHentschel
left a comment
There was a problem hiding this comment.
Thanks for the nice work! :)
Implementing suggestions of PR 476
Implementing suggestions of PR 476. Save/import workspace buttons. Fixed some typing issues.
As per your suggestion, 2a97b29 implements save/load workspace buttons. |
Implement confirmation box for clearing environment. Implemented getWorkspacePath(), which returns the current workspace folder.
|
Maybe we should rename the file |
Rename workspace to workspaceViewer, add settings option for removing hidden items, sort elements in workspace viewer, fixed some typings
Use workingDir instead of getWorkspacePath()
Change sort function from ternary form to if-else form
|
I've noticed that open/save workspace require the R session to be attached for them to work. Is there a way to force attach or require attach? |
If Currently, I suggest that you check if |
Don't run workspace viewer commands unless globalenv is defined
Use dim() where possible for data.frame-like element descriptions
|
@ElianHugh Thanks for the updated. Please notice and fix the eslint complains in the diffs. |
Will do! For some reason my local eslint isn't picking up some of these errors... |
|
I think we should make a decision re: which data types use the
This leaves some data types potentially unaccounted for:
From what I can tell, RStudio seems to only treat list-type data structures as the Edit: Oops, just saw your post! |
Fixed a typo in getDescription, dim() only applied to list-type data structures
There was a problem hiding this comment.
LGTM
Thanks for your contribution to this feature!
@Ikuyadeu @andycraig @ManuelHentschel Any more comments?
|
@renkun-ken I won't have time to look at this for a while, so please proceed without me. |
|
@ElianHugh the workspace viewer relies on session watcher to work. Therefore, I guess we don't need to create workspace viewer if session watcher is disabled? Not sure if it is possible, but an alternative way is to tell user one must enable session watcher to use the feature in the default text if it finds that session watcher is disabled? |
|
@renkun-ken LGTM |
Great! Thank you very much for help and suggestions!
Hmm, that's a good point. I think it should be possible to hide the viewer when session watcher is disabled via the package.json file (when property). I'll try it out in a little bit. |


What problem did you solve?
Closes #416, implementing a workspace/environment viewer.
Screenshot
How can I check this pull request?
What should happen:
Changelog
c3f3c17
2a97b29
7b4edd4
8c86577
44f0b79
9e2eef3
fd06ed0
defaultUri: Uri.file(workingDir + path.sep + 'workspace.RData')todefaultUri: Uri.file(${workingDir}${path.sep}workspace.RData)dd912c9
cf1ef1f
d9eb94c
2bae9c0
6cc95e8
4036a19
f822da8