Find in topic (help panel) #463#488
Merged
renkun-ken merged 6 commits intoREditorSupport:masterfrom Dec 10, 2020
Merged
Conversation
Member
ManuelHentschel
left a comment
ManuelHentschel
left a comment
There was a problem hiding this comment.
Thanks for the improvement, works really nicely!
Comment on lines
398
to
405
| if(!this.panel){ | ||
| const webViewOptions: WebviewOptions = { | ||
| enableScripts: true, | ||
| const webViewOptions: WebviewOptions & WebviewPanelOptions = { | ||
| enableScripts: true, | ||
| enableFindWidget: true | ||
| }; | ||
| this.panel = window.createWebviewPanel('rhelp', 'R Help', this.viewColumn, webViewOptions); | ||
|
|
||
| this.panel = window.createWebviewPanel('rhelp', 'R Help', this.viewColumn, webViewOptions); | ||
| // virtual uris used to access local files |
Member
There was a problem hiding this comment.
Please fix the indentation here :)
Contributor
Author
There was a problem hiding this comment.
Is there a reason why space- and tab-indentation is mixed in the project? Why not stick with one style (preferring spaces)?
Member
There was a problem hiding this comment.
I'd assume that is just the result of the different defaults/preferences from different developers. This could probably be fixed by some linter rule
Member
|
Tested on macOS and it works quite nicely. |
Ikuyadeu
reviewed
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #463
Is your feature request related to a problem? Please describe.
Search for words, code snippets, etc. in a manual opened by HelpView
Describe the solution you'd like
Add an icon to the top of the panel which opens a search field if clicked. If the user starts typing, highlight the matching elements in the content of the view, and let the user step through the hits.