Skip to content

Enable find widget in WebViews#490

Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken:enable-find-widget
Dec 10, 2020
Merged

Enable find widget in WebViews#490
renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken:enable-find-widget

Conversation

@renkun-ken
Copy link
Copy Markdown
Member

What problem did you solve?

Inspired by #488, this PR uses enableFindWidget for all non-http web views.

(If you have)Screenshot

image

image

(If you do not have screenshot) How can I check this pull request?

View(mtcars)
View(list(a = 1, b = 2))
DT::datatable(mtcars)

The find widget should work in each WebView created by the above lines.

@Ikuyadeu
Copy link
Copy Markdown
Member

LGTM

@renkun-ken renkun-ken merged commit bbd1d3e into REditorSupport:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants