Skip to content

Disable alwaysShow for addin items#491

Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken:filter-addins
Dec 10, 2020
Merged

Disable alwaysShow for addin items#491
renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken:filter-addins

Conversation

@renkun-ken
Copy link
Copy Markdown
Member

What problem did you solve?

Closes #489

This PR sets alwaysShow: false to addin items so that it is easier for user to find the wanted addin command on type.

(If you have)Screenshot

image

(If you do not have screenshot) How can I check this pull request?

  1. Attach an R session
  2. Launch RStudio Addin
  3. type a package name
  4. Only matched items will show in the list

@renkun-ken
Copy link
Copy Markdown
Member Author

@MilesMcBain Is there a reason that alwaysShow: true was used?

@MilesMcBain
Copy link
Copy Markdown
Collaborator

Only because I seem to have misunderstood what it did.

LGTM

@renkun-ken renkun-ken merged commit d74d7f7 into REditorSupport:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addin picker sorting

2 participants