Add browser WebView command buttons#494
Conversation
|
Works nicely, thanks! I added a small change that hides the help-panel controls after closing the help panel (this was previously done only on changeViewState events). Would it be possible/feasible to implement the back and forward buttons for general webviews? E.g. after calling |
|
Thanks for the review!
The browser WebView is mainly used to show reactive content (e.g. shiny apps, httpgd graphics) rather than general purpose web browsing. I suspect if it is really useful to be able to go backward/forward on the page since most reactive content is not designed to work with such navigation operations. |
What problem did you solve?
This PR adds the following buttons to WebViews created by
browser.Also, this PR uses
vscode.env.asExternalUriintroduced at https://code.visualstudio.com/api/advanced-topics/remote-extensions#forwarding-localhost instead of port mapping. Now the port forwarding should work smoothly under remote development when a browser WebView is created without relying on explicit port mapping (currently not working, see microsoft/vscode#102449) and auto port forwarding (currently not working smoothly, see microsoft/vscode#112297).(If you have)Screenshot
(If you do not have screenshot) How can I check this pull request?
shiny::runExample("01_hello")and a WebView is created"Open in external browser" should also work under remote development as it will automatically setup the port forwarding from remote to local. To test, just repeat the above steps under remote development and the behavior should be exactly the same.