Skip to content

releaseAction#505

Merged
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:releaseAction
Dec 27, 2020
Merged

releaseAction#505
Ikuyadeu merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:releaseAction

Conversation

@ManuelHentschel
Copy link
Copy Markdown
Member

What problem did you solve?
Fix #503. This PR updates the GitHub release action to automatically release the extension to GitHub and the marketplace when a tag matching v* is pushed.

How can I check this pull request?
This PR is kind of hard to check safely since the action is triggered automatically and produces a release to the marketplace, which can potentially affect all users of the extension. To be safe, I'd suggest keeping a .vsix file ready as backup when using the action for the first time.

For the action to publish to the marketlace, an access token is required, more details e.g. here.

@Ikuyadeu
Copy link
Copy Markdown
Member

@ManuelHentschel Thank you for improving our releasing process. The changes look good to me.
To make security safety, I'll check the detail of secret tokens' access this weekend.

@Ikuyadeu Ikuyadeu self-assigned this Dec 24, 2020
@Ikuyadeu Ikuyadeu added the engineering Maintenance, style, development process label Dec 24, 2020
@ManuelHentschel
Copy link
Copy Markdown
Member Author

While we're on it, we could also consider publishing a development build of the extension, similar to what Microsoft does with their GiHub Pull Requests:

This would allow people that are interested in the extension to follow development closely without having to manually install from .vsix files all the time.

Setting this up should be rather easy, we'd just need to add a step that sets "preview": true, in the package.json and adds a note to the README.

Do you think people would be interested in this?

@Ikuyadeu
Copy link
Copy Markdown
Member

OK, I set the secret, and I'll try it now.

@Ikuyadeu Ikuyadeu merged commit 1dd60e7 into REditorSupport:master Dec 27, 2020
@Ikuyadeu
Copy link
Copy Markdown
Member

@ManuelHentschel Before using the new function of vscode, we need to fix the source code for the new vscode API.
Usually, I did that work before publishing, but I am working on #508 because it will be large fixing in this time.
I hope you will help me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineering Maintenance, style, development process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Releases

2 participants