Skip to content

WIP: Pre fixing for version 1.6.3#508

Merged
Ikuyadeu merged 6 commits intomasterfrom
pre_fix
Jan 1, 2021
Merged

WIP: Pre fixing for version 1.6.3#508
Ikuyadeu merged 6 commits intomasterfrom
pre_fix

Conversation

@Ikuyadeu
Copy link
Copy Markdown
Member

@Ikuyadeu Ikuyadeu commented Dec 27, 2020

What problem did you solve?

Extends from #474

To publish a new version, we need to clean up the whole new source code.

How can I check this pull request?
I want to solve the following problems

  • Fix eslint problems on rHelps.ts and rHelpTree.ts by defining the interface
  • Apply for new cheerio API
  • Apply for new vscode API

@Ikuyadeu Ikuyadeu mentioned this pull request Dec 27, 2020
@ManuelHentschel
Copy link
Copy Markdown
Member

I fixed the eslint warnings in the help related code and adapted it to the new cheerio/vscode APIs.
I left some of the eslint-disable statements in the code, in places where I don't see a better/safer way to achieve the same thing (e.g. when the entire line is wrapped in try-catch anyways).

The tests performed by GitHub actions seem to fail "randomly" sometimes and re-running solves the problem, no idea what's going on there...

@Ikuyadeu Ikuyadeu marked this pull request as ready for review January 1, 2021 09:26
@Ikuyadeu
Copy link
Copy Markdown
Member Author

Ikuyadeu commented Jan 1, 2021

@ManuelHentschel Thank you for your help!
OK, I merge this and publish a new version.

@Ikuyadeu Ikuyadeu merged commit f937fe9 into master Jan 1, 2021
@Ikuyadeu Ikuyadeu deleted the pre_fix branch January 1, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants