Add option to keep terminal hidden after running code#566
Merged
andycraig merged 2 commits intoREditorSupport:masterfrom Mar 6, 2021
Merged
Add option to keep terminal hidden after running code#566andycraig merged 2 commits intoREditorSupport:masterfrom
andycraig merged 2 commits intoREditorSupport:masterfrom
Conversation
Member
|
Works as expected. It looks like we have two ways to address this:
From the perspective of improving an existing option rather than introducing a new one, I guess the one option makes more sense to me. |
Collaborator
Author
|
@renkun-ken Thank you for the review! Exactly, I agree that there's two possible approaches here. In the issue discussion I initially proposed a new setting. Then I changed my mind and suggested it be added as a new option to the existing setting. As you note, it's hard to imagine anyone wanting the combination 'focus on the terminal but don't reveal it', and this way we avoid people choosing that combination accidentally. I will go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510
What problem did you solve?
This PR adds an option 'none' to
r.source.focusto keep the terminal hidden after sending code to the terminal.How can I check this pull request?
With session watcher on.
settings.json:R: Create R terminalplot(1, 1)Note
I believe
r.source.focusis the right setting for this option, but I am concerned that the difference between the options 'editor' and 'none' is not obvious. I have updated the description with this in mind so please check whether you think it is clear enough.