Skip to content

Send code to debug repl#582

Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:sendToRepl
Mar 25, 2021
Merged

Send code to debug repl#582
renkun-ken merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:sendToRepl

Conversation

@ManuelHentschel
Copy link
Copy Markdown
Member

Fix #570

Adds the possibility to send code directly to the debug console.

How to check:

  • Launch a debug session using VSCode-R-Debugger
  • In the .R file, press ctrl+enter
  • Expected behaviour: text that is usually sent to the terminal is instead sent to the debug repl

This PR is WIP and needs some more fine tuning, but the basic functionality should be working.

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Mar 21, 2021

Nice! What happens if the user already selected text? I'd expect that this (and only this) text is sent to the REPL.

@ManuelHentschel
Copy link
Copy Markdown
Member Author

Nice! What happens if the user already selected text? I'd expect that this (and only this) text is sent to the REPL.

The behaviour should be the same as with normal terminals, since I'm using the same background functions to select the text

@ManuelHentschel ManuelHentschel marked this pull request as ready for review March 21, 2021 22:17
@ManuelHentschel ManuelHentschel changed the title WIP: Send code to debug repl Send code to debug repl Mar 22, 2021
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Mar 25, 2021

Works for me, thanks!

Copy link
Copy Markdown
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. LGTM. Thanks!

@renkun-ken renkun-ken merged commit f4a6860 into REditorSupport:master Mar 25, 2021
@ManuelHentschel ManuelHentschel deleted the sendToRepl branch April 1, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send code to debug window

3 participants