Thread execute argument through to term.sendText()

[krlmlr]

Closes #575.

I have no Idea if this code works, can't build: seeing Error: Cannot find module 'copy-webpack-plugin' when pressing F5 or Ctrl + Shift + B in VS Code.

There must be a better way to detect the last item in an iteration.

This code now also avoids the delay before the first line in non-bracketed paste.

[andycraig]

Thanks for the PR! Can you try running this at the command line before pressing F5? That will hopefully fix the error.

# In directory vscode-R
npm install

[krlmlr]

Works for me now.

Unrelated: I think I have made a mess on my system with various runs of apt install node-... and sudo npm install -g calls. Ideally I'd like to have a clean per-project setup, without systemwide installations. What's a good reference to get started?

[krlmlr]

I forgot to mention: the console message changed, "inserting" is shown with execute = FALSE, "sending" is now the default.

[krlmlr]

Done, tests succeed now. What's a good location for a test of this functionality?

[andycraig]

We don't have any unit tests for these functions that call term.sendText(), so I don't think it's necessary to add any tests as part of this PR.

Sounds like it's ready for review?

[krlmlr]

Yes, the implementation works for me.

[andycraig]

I've added a couple of minor notes, and everything else looks good.

I think you're using this with {fledge}, right? Could you write down the steps I can follow to cause it to send some text to the console without executing it? I'll follow those steps to test this PR. Thanks!

[krlmlr]

I test with:

rstudioapi::sendToConsole("test()", execute = FALSE)
rstudioapi::sendToConsole("test(\n)", execute = FALSE)

I have tested the following combinations:

• ✔️ radian with bracketed paste
• ✔️ R with non-bracketed paste
• ⚔️ radian with non-bracketed paste: In the above example, the closing parenthesis is inserted automatically

[andycraig]

LGTM and works as described. Thank you for the PR!