shim the rstudioapi if it has already been loaded#610
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Apr 7, 2021
Merged
shim the rstudioapi if it has already been loaded#610renkun-ken merged 2 commits intoREditorSupport:masterfrom
renkun-ken merged 2 commits intoREditorSupport:masterfrom
Conversation
fixes bug reported in REditorSupport#605
renkun-ken
approved these changes
Apr 7, 2021
Member
renkun-ken
left a comment
renkun-ken
left a comment
There was a problem hiding this comment.
LGTM
Works as expected. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes bug reported in #605
What problem did you solve?
If the user has something in their .Rprofile that refers to the
rstudioapinamespace, then that causes the namespace to be loaded before we can attach our onLoad hook in the extension R session initialisation routine.RStudio Addins can be browsed via the picker, but not run in this case.
(If you do not have screenshot) How can I check this pull request?
If you want to verify the bug you can add
rstudioapi::is_available()to your alongsidevsc.rstudioapi = TRUEin your.Rprofileand then try to runrstudioapi::insert_text("test")You should see:
Error: RStudio not runningWith this PR in place, try the same sequence and the text will be inserted into the current text editor window.