Prefer rPath from PATH#649
Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom May 29, 2021
Merged
Conversation
renkun-ken
approved these changes
May 28, 2021
Member
renkun-ken
left a comment
renkun-ken
left a comment
There was a problem hiding this comment.
PATH taking the highest precedence in the determination of R path makes good sense.
Member
|
Are you interested in putting up a PR to also update vscode-r-lsp util.ts so that they are consistent in finding R path? |
This was referenced May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
This PR changes the order in which the extension tries to find an R path on windows.
I think it makes sense to prefer
PATHover the registry since this is more transparent and makes it easier to switch between R versions systemwide (i.e. normal terminals and vscode-R).How can I check this pull request?
Leave
r.rterm.windowsempty, have different r paths in thePATHenvironment variable and registry, and runR: create R Terminal