Skip to content

Fix Webview Identification Function#650

Merged
ManuelHentschel merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:fixWebviewId
May 31, 2021
Merged

Fix Webview Identification Function#650
ManuelHentschel merged 2 commits intoREditorSupport:masterfrom
ManuelHentschel:fixWebviewId

Conversation

@ManuelHentschel
Copy link
Copy Markdown
Member

@ManuelHentschel ManuelHentschel commented May 27, 2021

What problem did you solve?

In the most recent insider-build of vscode, some webview commands are broken because the internal function Webview.asWebviewUri() changed its behavior.

How can I check this pull request?

Should fix the issue mentioned above.

Copy link
Copy Markdown
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Works well with latest 1.57.0-insider on Ubuntu.

@ManuelHentschel ManuelHentschel merged commit f8bf61e into REditorSupport:master May 31, 2021
@ManuelHentschel ManuelHentschel deleted the fixWebviewId branch May 31, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants