Don't run chunks with eval = FALSE. Fixes #651#653
Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom May 30, 2021
jolars:master
Merged
Don't run chunks with eval = FALSE. Fixes #651#653renkun-ken merged 1 commit intoREditorSupport:masterfrom jolars:master
renkun-ken merged 1 commit intoREditorSupport:masterfrom
jolars:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
When using the code lens actions in the extension, such as "Run Above", code chunks with
eval = FALSEare evaluated although they probably should not be since they often contain pseudo-code or other things that are not intended to actually be run. The default behavior in R Studio, for instance, is not to run these code chunks. See #653 for more details.The extension already collects information on the value of
eval, so the fix is just to implement a few if-clauses to prevent evaluation wheneval = FALSE. I purposely did not include actionsrunNextChunk,runPreviousChunk,runCurrentChunk, andrunCurrentAndBelowChunkssince I think they signal that the user explicitly wants the specific chunk to be run. This also conforms to the behavior in R Studio when using "Run Next Chunk" and "Run Current Chunk".Screenshot