Catch LiveShare API errors#679
Merged
ElianHugh merged 1 commit intoREditorSupport:masterfrom Jun 20, 2021
ElianHugh:share-changes
Merged
Catch LiveShare API errors#679ElianHugh merged 1 commit intoREditorSupport:masterfrom ElianHugh:share-changes
ElianHugh merged 1 commit intoREditorSupport:masterfrom
ElianHugh:share-changes
Conversation
Primary change: - Adds try/catch to the accessing of the vsls API, so as to hopefully avoid situations such as #671 Minor changes: - Remove some superflous code from previous iterations of the LiveShare PR - Change the guest dataview file to have the same path as the host Tested on Arch Linux
Member
|
I test on macOS with a corrupted live share installation (some extension files are removed deliberately) and vscode-R is activated successfully. When live share API is ok, the features work well too. |
Collaborator
Author
|
Thank you for checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change:
Minor changes:
Tested on Arch Linux