Skip to content

Small Plot Viewer adjustments#681

Merged
ManuelHentschel merged 5 commits intoREditorSupport:masterfrom
ManuelHentschel:plotViewer
Jun 21, 2021
Merged

Small Plot Viewer adjustments#681
ManuelHentschel merged 5 commits intoREditorSupport:masterfrom
ManuelHentschel:plotViewer

Conversation

@ManuelHentschel
Copy link
Copy Markdown
Member

@ManuelHentschel ManuelHentschel commented Jun 21, 2021

Addresses some issues that came up in the conversation of #678:

  • Fixes the CSS used to change font colors
  • Clarifies the description of two config entries

Also:

  • Removes some unnecessary logging output
  • Makes resizing the plot more "snappy" by not requesting an updated plot, while the previous request is still being handled

Copy link
Copy Markdown
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works quite well.

@ManuelHentschel ManuelHentschel merged commit b51e615 into REditorSupport:master Jun 21, 2021
@ManuelHentschel ManuelHentschel deleted the plotViewer branch June 21, 2021 15:19
@psobolewskiPhD
Copy link
Copy Markdown

psobolewskiPhD commented Jun 21, 2021

I got the css override to work!
It was problem between chair and keyboard, as usual.
I didn't realize my file had to be also named styleOverwrites.css.
So I made a css file with a name that was more meaningful to me.
Now it works wonderfully, with the palette icon swapping working perfectly and my MacOS auto/light dark working beautifully.
image
styleOverwrites.css tweaked to not have strokes on the symbols and legend.
With the snappier resizing I don't mind that empty area, its just a few times pulled down past the edge (where the bottom panel starts) and made a super long plot that was annoying to resize back to normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants