Remove show plot history command#706
Merged
renkun-ken merged 3 commits intoREditorSupport:masterfrom Jul 15, 2021
Merged
Conversation
ElianHugh
approved these changes
Jul 15, 2021
Collaborator
ElianHugh
left a comment
ElianHugh
left a comment
There was a problem hiding this comment.
LGTM, no unexpected issues while testing. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #686
Since the old plot viewer based on png replays is quite limited and in some cases it does not produce desired result (e.g. plot in a for loop, multi-page plots), I suggest we remove this feature in favor of the httpgd approach.
This PR removes the command "R: Show plot history" and related code that copies replayed png files in a history folder and removes the dependency on
fotorama.For better plot history support, use httpgd instead as introduced in the wiki.
(If you do not have screenshot) How can I check this pull request?
Disable httpgd plot viewer.
plot(rnorm(100))should correctly produce a png file which is open in a new tab. The "R: Show plot history" command is gone.