Skip to content

Auto refresh help#863

Merged
ManuelHentschel merged 3 commits intoREditorSupport:masterfrom
ManuelHentschel:rhelp
Nov 11, 2021
Merged

Auto refresh help#863
ManuelHentschel merged 3 commits intoREditorSupport:masterfrom
ManuelHentschel:rhelp

Conversation

@ManuelHentschel
Copy link
Copy Markdown
Member

@ManuelHentschel ManuelHentschel commented Nov 9, 2021

Fix #854

Ho to check:

  • Have vscode open, install a new package in a separate process, use R help viewer. The Package should show up in the corresponding lists.
  • Open the treeview R > Help Pages > Help Topics by Package, install/remove a package in a separate process. The treeview should automatically refresh to reflect the change.

Edit:
I also refactored a bit of help-related code to make implementing this a bit easier. The most relevant changes are in helpServer.R and helpProvider.ts.

Comment thread src/helpViewer/index.ts Outdated
Comment thread R/help/helpServer.R Outdated
Comment thread R/help/helpServer.R
Copy link
Copy Markdown
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManuelHentschel ManuelHentschel merged commit b47e93b into REditorSupport:master Nov 11, 2021
@ManuelHentschel ManuelHentschel deleted the rhelp branch November 11, 2021 07:54
ElianHugh pushed a commit to ElianHugh/vscode-R that referenced this pull request May 12, 2022
* Auto refresh help

* Use installed.packages to handle package updates

* Only write log when restarting help server

Co-authored-by: Kun Ren <renkun@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-refresh help topics

2 participants