Skip to content

Clean up of help related files#887

Merged
ManuelHentschel merged 5 commits intoREditorSupport:masterfrom
ManuelHentschel:cleanup
Nov 28, 2021
Merged

Clean up of help related files#887
ManuelHentschel merged 5 commits intoREditorSupport:masterfrom
ManuelHentschel:cleanup

Conversation

@ManuelHentschel
Copy link
Copy Markdown
Member

Includes some general clean up of help related files.

  • Convert methods to functions if they can be standalone
  • Correctly handle null/undefiend (set "strictNullChecks": true in tsconfig.json to check)

Comment thread src/helpViewer/helpProvider.ts Outdated
Comment thread src/helpViewer/helpProvider.ts Outdated
Copy link
Copy Markdown
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManuelHentschel ManuelHentschel merged commit 684616c into REditorSupport:master Nov 28, 2021
@ManuelHentschel ManuelHentschel deleted the cleanup branch November 28, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants