Skip to content

should use Strong quote for shell commands#964

Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom
shrektan:task-should-quote
Feb 3, 2022
Merged

should use Strong quote for shell commands#964
renkun-ken merged 1 commit intoREditorSupport:masterfrom
shrektan:task-should-quote

Conversation

@shrektan
Copy link
Copy Markdown
Contributor

@shrektan shrektan commented Feb 3, 2022

What problem did you solve?

Fixes #932

The cause of this issue is that different shell uses different quote style. The reliable way of doing that in VSCode is to use the vscode.ShellQuotedString.

(If you do not have screenshot) How can I check this pull request?

  1. Open any R package project.
  2. Cmd + Shift + P and choose any "R Package - xxx" command, e.g., "R Package - Document".
  3. You'll find the command executes as expected.
  4. Probably, you can switch to another Shell and test it again. For example, on Windows you can choose CMD or PowerShell, as the two use different quote for strings " for CMD and ' for PowerShell. Now the command generated will quote the string uses correct style.

(If you have)Screenshot

(Note that the commands in the two shells use different quote identifiers)

Windows, Powershell

截屏2022-02-03 21 48 19

Windows, CMD

image

Copy link
Copy Markdown
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken renkun-ken merged commit 55d6d67 into REditorSupport:master Feb 3, 2022
@shrektan shrektan deleted the task-should-quote branch February 3, 2022 14:09
@renkun-ken renkun-ken mentioned this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document not work now

2 participants