should use Strong quote for shell commands#964
Merged
renkun-ken merged 1 commit intoREditorSupport:masterfrom Feb 3, 2022
Merged
should use Strong quote for shell commands#964renkun-ken merged 1 commit intoREditorSupport:masterfrom
renkun-ken merged 1 commit intoREditorSupport:masterfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Fixes #932
The cause of this issue is that different shell uses different quote style. The reliable way of doing that in VSCode is to use the
vscode.ShellQuotedString.(If you do not have screenshot) How can I check this pull request?
"for CMD and'for PowerShell. Now the command generated will quote the string uses correct style.(If you have)Screenshot
(Note that the commands in the two shells use different quote identifiers)
Windows, Powershell
Windows, CMD