Fix incorrect syntax highlighting for variables starting with "function"#992
Merged
renkun-ken merged 3 commits intoREditorSupport:masterfrom Feb 17, 2022
gowerc:fix-function-syntax
Merged
Fix incorrect syntax highlighting for variables starting with "function"#992renkun-ken merged 3 commits intoREditorSupport:masterfrom gowerc:fix-function-syntax
renkun-ken merged 3 commits intoREditorSupport:masterfrom
gowerc:fix-function-syntax
Conversation
Contributor
Author
|
Looks like the unit tests have failed with:
I'm assuming this is because the environment variable |
Contributor
Author
|
@renkun-ken , fixed the bug with pathing for getting the config file, this is ready for review now. Please let me know if there is a better way of handling this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #982 - incorrect syntax highlighting for variables starting with the word
functionfunction-declarationsfile to make sure there are no additional word characters following thefunctionkeywordPlease let me know if there's a better way to test this or if you need me to refactor the code (am still learning node/ts/js/vscode).
(If you have)Screenshot