Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new protocol 114 for TR401 #1002

Merged
merged 7 commits into from
Aug 8, 2021
Merged

new protocol 114 for TR401 #1002

merged 7 commits into from
Aug 8, 2021

Conversation

HomeAutoUser
Copy link
Contributor

@HomeAutoUser HomeAutoUser commented Aug 6, 2021

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

    • no receive TR401 remote
  • What is the new behavior (if this is a feature change)?

    • receive TR401 remote
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:
    https://forum.fhem.de/index.php/topic,121103

HomeAutoUser and others added 2 commits August 6, 2021 08:18
 * Update 00_SIGNALduino.pm
   * added protocol 114 to SD_UT match
 * Update SD_ProtocolData.pm
    * added protocol 114
 * Update 14_SD_UT.pm
   * added model TR401
   * revised commandref
 * Update README.md
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #1002 (d54fe6e) into master (7cf77e6) will decrease coverage by 0.02%.
The diff coverage is 45.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   59.02%   59.00%   -0.03%     
==========================================
  Files         110      110              
  Lines        8747     8769      +22     
  Branches     1373     1376       +3     
==========================================
+ Hits         5163     5174      +11     
- Misses       2637     2645       +8     
- Partials      947      950       +3     
Flag Coverage Δ
fhem 49.32% <45.16%> (+<0.01%) ⬆️
modules 59.00% <45.16%> (-0.03%) ⬇️
perl 91.57% <ø> (ø)
unittests 59.00% <45.16%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
FHEM/14_SD_UT.pm 36.75% <43.33%> (+0.34%) ⬆️
FHEM/00_SIGNALduino.pm 62.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf77e6...d54fe6e. Read the comment docs.

@sidey79
Copy link
Contributor

sidey79 commented Aug 6, 2021

Das mit dem Changelog wird auch hier Käse, die Änderung ist dann doppelt eingetragen.
Hmm, das wird uns gefühlt immer passieren. :(

@HomeAutoUser
Copy link
Contributor Author

Was muss wie genau behandelt werden um nichts falsch zu machen? @elektron-bbs war ja auch schon darüber gestolpert.

@sidey79
Copy link
Contributor

sidey79 commented Aug 7, 2021

Die Idee die ich hatte war, dass wir Changed nicht aktualisieren lassen, wenn ein pull Requests offen ist.
Genau das habe ich auch implementiert, weil sich die commits ja derzeit in changed wiederfinden.
Im master macht es changed dann einfach total unübersichtlich, da reicht meist ein Eintrag.

Jetzt ist es aber so, dass jeder commit weiterhin einen Eintrag in Changed generiert, solange kein Pullrequests offen ist.
Das passiert mindestens einmal beim 1. Push in einen neuen Branche und auch wenn ein Pull Requests in den master übergeben wird.

Letztendlich hilft hier nur die workflows so anzupassen, dass das nicht passiert.

Vermeintlich ist hier die einfachste Variante womöglich Changed nur noch im Master automatisch zu aktualisieren.

Bis da hin bleibt nur, manuell changed aufzuräumen bevor der PR an den master Branche übergeben wird.

@HomeAutoUser
Copy link
Contributor Author

Ich verstehe dein Ansinnen.
Aus diesem Grund habe ich aus meinem Branch diesen Stand in einen Branch hier manuell genommen. Somit ergibt sich nur ein Changed Eintrag mit allen Anpassungen wie ich diese gerade getan habe.

Der Stand des Branches ist final und normaler weise kommt nichts mehr hinzu.

@sidey79
Copy link
Contributor

sidey79 commented Aug 7, 2021

Es nützt leider nichts, im Moment müssen die Änderung Changed in den Feature Branches manuell entfernt werden, sonst haben wir es doppelt im Master.

@HomeAutoUser
Copy link
Contributor Author

Verstehe ich das richtig, hier wäre nun folgende Handlung notwendig,
Changed von Hand leeren und dann beim Click auf Merge den Text nur anpassen?

@sidey79
Copy link
Contributor

sidey79 commented Aug 7, 2021

Also damit keine Missverständnisse aufkommen, folgende Zeilen löschen und die relevante Information dann in das merge summary feld eingeben:

RFFHEM/CHANGED

Lines 1 to 10 in d5ff502

2021-08-06 - new protocol 114 for TR401
* Update 00_SIGNALduino.pm
* added protocol 114 to SD_UT match
* Update SD_ProtocolData.pm
* added protocol 114
* Update 14_SD_UT.pm
* added model TR401
* revised commandref
* Update README.md

@HomeAutoUser
Copy link
Contributor Author

Ich werde die Änderungen morgen vornehmen. @sidey79 , @elektron-bbs Gern kann auch jemand anderes die markierten Zeilen entfernen und dies als Erklärung im MergeFeld nutzen.

@sidey79
Copy link
Contributor

sidey79 commented Aug 8, 2021

Merge Text

  
2021-08-06 - new protocol 114 for TR401 ( #1002  )

 * 00_SIGNALduino.pm:   added protocol 114 to SD_UT match
 * SD_ProtocolData.pm:   added protocol 114
 * 14_SD_UT.pm:  added model TR401
 * README.md: Updated

@HomeAutoUser
Copy link
Contributor Author

Jo :)

@sidey79 sidey79 merged commit ed06e2a into master Aug 8, 2021
@sidey79 sidey79 deleted the master_SD_UT_TR401 branch August 8, 2021 17:14
@sidey79 sidey79 mentioned this pull request Jan 16, 2022
sidey79 added a commit that referenced this pull request Jan 16, 2022
Release 3.5.2 
     10_SD_Rojaflex.pm 
          new: Module for rojaflex remote controls

     90_SIGNALduino_un.pm
          changed: fix some PerlCritic hints (#914)
          changed: revised commandref

     00_SIGNALduino.pm:
          feature: xFSK processing
          feature: Added support for directio and none.
          feature: Extension for "get sduino ccreg" (#918)
          feature: parse subs optimized (#926)
          feature: update reading  config when change settings (#948)
          feature: Allow incremental addition of match list entries (#1026)
          change: added N to send SN  xFSK sendCommand
          change: added new sub SIGNALduino_calcRSSI to simplification code
          change: revised Parse_MN and loglevel
          change: revised logoutput text SIGNALduino_Get_Command
          change: rename "get raw" to "get rawmsg" (#925)
          feature: added commandref rfmode & cc1101_reg_user
          feature: added hardware ESP32cc1101, MAPLEMINI_F103CB on attribute
          feature: added new attrib rfmode to changed to xFSK & revised commandref
          feature: added separat sub SIGNALduino_Attr_rfmode
          feature: added set cmd LaCrossePairForSec (for LaCrosse
          bugfix: SIGNALduino_CheckccConfResponse is more robust #1015 (#1031)
          bugfix: fix PERL WARNING (#895) (#972)
          bugfix: get ccreg command caused stacktrace #898
          bugfix: Bugfix define with hostname 901 (#904)
          bugfix: Wrong version assignment fixed
          Bugfix, module runs now without fhemweb instance 
          bugfix: display protocol list (#947)
          bugfix: require 99_Utils only if really needed (#950)
          bugfix: corrected incorrect logoutput (#951)
          bugfix: Fix Multiple send delay (#941)
          bugfix: Fixes high CPU and MEM usage in patternExists (#988)

  SD_Protocols.pm:
          change: moved subs for converting in own package
                  ConvLaCrosse, ConvKoppFreeControl and ConvPCA301
          bugfix: Hideki fix inverted message (#974)

  SD_ProtocolData.pm
          feature: added rfmode, register rubric & comments
          change: fix perlcritic Severity 3 - hard tabs
          feature: Added crc checksum verification Revolt (#956)

  14_SD_WS.pm: 
         feature: protocol 27 for sensor EFS-3110A (#890)
         feature: protocol 106 for GT-TMBBQ-0   
         feature: protocol 110 for ADE WS1907 Weather station (#970)
         feature: protocol 111 for TS-FT002 water tank level (#1000)
         feature: protocol 113 for GFGT 433 B1 Wireless Grill sensor (#1003)
         feature: new protocol 108 for BRESSER 5-in-1 Weather Center
                  and BRESSER Professional Rain Gauge (#973)
         feature: protocol 115 for Bresser 6-in-1 and 
                  5-in-1 Comfort Wetter Center (#1010)
         feature: new protocol 107 for Fine Offset WH51 (#1055)
         feature: new protocol 116 for Fine Offset WH57 (#1061)
         bugfix: Update protocol 64 for sensor WH2A (#1009)
         bugfix: Conrad S522 protocol 33 no reading batteryState (#1042)

  14_SD_WS07.pm: 
         feature: protocol definition 7.1 for Mebus HQ7312-2 (#1050)

  14_FLAMINGO.pm: 
         change: Perlcritic (#887)

  14_SD_UT.pm:
         change: PerlCritic (#877)
         feature: new protocol 105 for remote control BF-301
         feature: decode and send protocol 56 remote control AC114-01B (#910)
         feature: decode and send protocol for Visivo remote control
         feature: Remote control SEAV BeSmart S4 (#933)
         feature: new protocol 114 for TR401 (#1002)

 14_SD_BELL.pm:
         change: PerlCritic (#877)
         change: Adjusted little things (#937)
         feature: added AVANTEK Wireless doorbell & LED night light (#981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants