Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require 99_Utils only if really needed #950

Merged
merged 3 commits into from
Mar 18, 2021
Merged

require 99_Utils only if really needed #950

merged 3 commits into from
Mar 18, 2021

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Mar 15, 2021

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    BugFix

  • What is the current behavior? (You can also link to an open issue here)

99_Utils is loaded even if it is already loaded.

  • What is the new behavior (if this is a feature change)?

99_Utils is only loaded, if the module isn't loaded before

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

This avids perl warnings, that functions are redeclared

Check if 99_Utils is already loaded to avoid perl warnings
@sidey79 sidey79 changed the title 00_SIGNALduino.pm require 99_Utils only if really needed Mar 15, 2021
@sidey79 sidey79 linked an issue Mar 15, 2021 that may be closed by this pull request
HomeAutoUser
HomeAutoUser previously approved these changes Mar 15, 2021
@sidey79
Copy link
Contributor Author

sidey79 commented Mar 15, 2021

Ich warte mal, bis die Checks wieder laufen.

Hast Du ihn bei dir mal testweise geladen diesen Branch?

Updated version
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #950 (3ac56cd) into master (62bf038) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #950   +/-   ##
=======================================
  Coverage   58.11%   58.11%           
=======================================
  Files         105      105           
  Lines        8409     8409           
  Branches     1314     1314           
=======================================
  Hits         4887     4887           
  Misses       2637     2637           
  Partials      885      885           
Flag Coverage Δ
fhem 48.39% <100.00%> (ø)
modules 58.11% <100.00%> (ø)
perl 91.42% <ø> (ø)
unittests 58.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 61.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62bf038...3ac56cd. Read the comment docs.

@HomeAutoUser
Copy link
Contributor

Hast Du ihn bei dir mal testweise geladen diesen Branch?

@sidey79 ja habe ich. funktioniert.

@sidey79 sidey79 merged commit 10382c4 into master Mar 18, 2021
@sidey79 sidey79 deleted the sidey79/issue949 branch March 18, 2021 22:17
@sidey79 sidey79 removed a link to an issue Mar 18, 2021
@sidey79 sidey79 linked an issue Mar 18, 2021 that may be closed by this pull request
sidey79 added a commit that referenced this pull request Jan 16, 2022
Release 3.5.2 
     10_SD_Rojaflex.pm 
          new: Module for rojaflex remote controls

     90_SIGNALduino_un.pm
          changed: fix some PerlCritic hints (#914)
          changed: revised commandref

     00_SIGNALduino.pm:
          feature: xFSK processing
          feature: Added support for directio and none.
          feature: Extension for "get sduino ccreg" (#918)
          feature: parse subs optimized (#926)
          feature: update reading  config when change settings (#948)
          feature: Allow incremental addition of match list entries (#1026)
          change: added N to send SN  xFSK sendCommand
          change: added new sub SIGNALduino_calcRSSI to simplification code
          change: revised Parse_MN and loglevel
          change: revised logoutput text SIGNALduino_Get_Command
          change: rename "get raw" to "get rawmsg" (#925)
          feature: added commandref rfmode & cc1101_reg_user
          feature: added hardware ESP32cc1101, MAPLEMINI_F103CB on attribute
          feature: added new attrib rfmode to changed to xFSK & revised commandref
          feature: added separat sub SIGNALduino_Attr_rfmode
          feature: added set cmd LaCrossePairForSec (for LaCrosse
          bugfix: SIGNALduino_CheckccConfResponse is more robust #1015 (#1031)
          bugfix: fix PERL WARNING (#895) (#972)
          bugfix: get ccreg command caused stacktrace #898
          bugfix: Bugfix define with hostname 901 (#904)
          bugfix: Wrong version assignment fixed
          Bugfix, module runs now without fhemweb instance 
          bugfix: display protocol list (#947)
          bugfix: require 99_Utils only if really needed (#950)
          bugfix: corrected incorrect logoutput (#951)
          bugfix: Fix Multiple send delay (#941)
          bugfix: Fixes high CPU and MEM usage in patternExists (#988)

  SD_Protocols.pm:
          change: moved subs for converting in own package
                  ConvLaCrosse, ConvKoppFreeControl and ConvPCA301
          bugfix: Hideki fix inverted message (#974)

  SD_ProtocolData.pm
          feature: added rfmode, register rubric & comments
          change: fix perlcritic Severity 3 - hard tabs
          feature: Added crc checksum verification Revolt (#956)

  14_SD_WS.pm: 
         feature: protocol 27 for sensor EFS-3110A (#890)
         feature: protocol 106 for GT-TMBBQ-0   
         feature: protocol 110 for ADE WS1907 Weather station (#970)
         feature: protocol 111 for TS-FT002 water tank level (#1000)
         feature: protocol 113 for GFGT 433 B1 Wireless Grill sensor (#1003)
         feature: new protocol 108 for BRESSER 5-in-1 Weather Center
                  and BRESSER Professional Rain Gauge (#973)
         feature: protocol 115 for Bresser 6-in-1 and 
                  5-in-1 Comfort Wetter Center (#1010)
         feature: new protocol 107 for Fine Offset WH51 (#1055)
         feature: new protocol 116 for Fine Offset WH57 (#1061)
         bugfix: Update protocol 64 for sensor WH2A (#1009)
         bugfix: Conrad S522 protocol 33 no reading batteryState (#1042)

  14_SD_WS07.pm: 
         feature: protocol definition 7.1 for Mebus HQ7312-2 (#1050)

  14_FLAMINGO.pm: 
         change: Perlcritic (#887)

  14_SD_UT.pm:
         change: PerlCritic (#877)
         feature: new protocol 105 for remote control BF-301
         feature: decode and send protocol 56 remote control AC114-01B (#910)
         feature: decode and send protocol for Visivo remote control
         feature: Remote control SEAV BeSmart S4 (#933)
         feature: new protocol 114 for TR401 (#1002)

 14_SD_BELL.pm:
         change: PerlCritic (#877)
         change: Adjusted little things (#937)
         feature: added AVANTEK Wireless doorbell & LED night light (#981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERL WARNING
3 participants