Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new protocol 115 for Bresser 6-in-1 and new 5-in-1 Comfort Wetter Center #1010

Merged
merged 20 commits into from
Aug 30, 2021

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    No decoding of the new protocol for Bresser 5-in-1
    Protokoll für Bresser 5CH Temp Hygro #607 (comment)

  • What is the new behavior (if this is a feature change)?
    Decoding of the new protocol for Bresser 5-in-1 and 6-in-1

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1010 (124e0f2) into master (f6516a4) will increase coverage by 0.19%.
The diff coverage is 82.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   49.85%   50.04%   +0.19%     
==========================================
  Files         217      218       +1     
  Lines       15184    15272      +88     
  Branches     2841     2855      +14     
==========================================
+ Hits         7570     7643      +73     
- Misses       5992     5994       +2     
- Partials     1622     1635      +13     
Flag Coverage Δ
fhem 50.24% <71.92%> (+0.16%) ⬆️
modules 50.04% <82.02%> (+0.19%) ⬆️
perl 51.00% <93.75%> (+0.24%) ⬆️
unittests 50.04% <82.02%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
FHEM/14_SD_WS.pm 64.28% <67.50%> (+0.19%) ⬆️
FHEM/lib/SD_Protocols.pm 79.03% <81.25%> (+0.04%) ⬆️
FHEM/00_SIGNALduino.pm 62.75% <100.00%> (ø)
t/SD_Protocols/02_ConvBresser_6in1.t 100.00% <100.00%> (ø)
local/lib/perl5/Test2/Util/HashBase.pm 46.87% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6516a4...124e0f2. Read the comment docs.

@sidey79
Copy link
Contributor

sidey79 commented Aug 27, 2021

Ich schau es mir kommende Woche an.
Derzeit nur mobil fehlt mir da der Überblick

@sidey79 sidey79 linked an issue Aug 29, 2021 that may be closed by this pull request
@sidey79 sidey79 added the SD_WS label Aug 29, 2021
@sidey79
Copy link
Contributor

sidey79 commented Aug 29, 2021

Ich habe mal drüber geschaut und konnte den Test für ConvBresser_6in1 nicht finden.

@elektron-bbs
Copy link
Contributor Author

Die Testdaten sind hier: RFD-FHEM/SIGNALduino_TOOL@13eef1f

@sidey79
Copy link
Contributor

sidey79 commented Aug 29, 2021

Die habe ich gesehen, aber das meinte ich nicht.

@elektron-bbs
Copy link
Contributor Author

Ich habe an deinen Testroutinen nichts geändert.
Braucht es denn für jedes Protokoll andere Tests? Ich dachte, du hast da etwas universelles programmiert, das bei jedem Protokoll die Readings prüft.

@sidey79
Copy link
Contributor

sidey79 commented Aug 29, 2021

Du hast eine neue Funktion erstellt.
Dafür gibt es noch keine Testroutine die auch Fehlerzustände verifiziert.

Die readings und das dispatch Ergebnis werden bereits getestet, das stimmt.

@elektron-bbs
Copy link
Contributor Author

Meinst du die sub ConvBresser_6in1 in SD_Protocols.pm?
Das müsste dann ähnlich aussehen, wie in 02_ConvBresser_5in1.t.
Brauchst du dafür noch Testdaten?

@sidey79
Copy link
Contributor

sidey79 commented Aug 29, 2021

Ja genau das meinte ich, ob dafür noch Testdaten nötig sind, weiss ich im Moment noch nicht :)

sidey79 and others added 2 commits August 29, 2021 22:28
@sidey79
Copy link
Contributor

sidey79 commented Aug 29, 2021

Ich habe die Datei angelegt, aber ja wir brauchen dafür noch die richtigen Testdaten.
Die übergebenen Hexwerte konnte ich im Log nicht finden und für den Fall dass der CRC stimmt aber die Summe nicht, wird schon etwas kniffelig.

- Error messaage adapted like other subs
Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich denke es passt dann so

@elektron-bbs elektron-bbs merged commit f007244 into master Aug 30, 2021
@elektron-bbs
Copy link
Contributor Author

Ich habe es auch nochmal auf meine Art getestet - passt.

@elektron-bbs elektron-bbs deleted the master_Bresser6in1 branch October 4, 2021 18:46
@sidey79 sidey79 mentioned this pull request Jan 16, 2022
sidey79 added a commit that referenced this pull request Jan 16, 2022
Release 3.5.2 
     10_SD_Rojaflex.pm 
          new: Module for rojaflex remote controls

     90_SIGNALduino_un.pm
          changed: fix some PerlCritic hints (#914)
          changed: revised commandref

     00_SIGNALduino.pm:
          feature: xFSK processing
          feature: Added support for directio and none.
          feature: Extension for "get sduino ccreg" (#918)
          feature: parse subs optimized (#926)
          feature: update reading  config when change settings (#948)
          feature: Allow incremental addition of match list entries (#1026)
          change: added N to send SN  xFSK sendCommand
          change: added new sub SIGNALduino_calcRSSI to simplification code
          change: revised Parse_MN and loglevel
          change: revised logoutput text SIGNALduino_Get_Command
          change: rename "get raw" to "get rawmsg" (#925)
          feature: added commandref rfmode & cc1101_reg_user
          feature: added hardware ESP32cc1101, MAPLEMINI_F103CB on attribute
          feature: added new attrib rfmode to changed to xFSK & revised commandref
          feature: added separat sub SIGNALduino_Attr_rfmode
          feature: added set cmd LaCrossePairForSec (for LaCrosse
          bugfix: SIGNALduino_CheckccConfResponse is more robust #1015 (#1031)
          bugfix: fix PERL WARNING (#895) (#972)
          bugfix: get ccreg command caused stacktrace #898
          bugfix: Bugfix define with hostname 901 (#904)
          bugfix: Wrong version assignment fixed
          Bugfix, module runs now without fhemweb instance 
          bugfix: display protocol list (#947)
          bugfix: require 99_Utils only if really needed (#950)
          bugfix: corrected incorrect logoutput (#951)
          bugfix: Fix Multiple send delay (#941)
          bugfix: Fixes high CPU and MEM usage in patternExists (#988)

  SD_Protocols.pm:
          change: moved subs for converting in own package
                  ConvLaCrosse, ConvKoppFreeControl and ConvPCA301
          bugfix: Hideki fix inverted message (#974)

  SD_ProtocolData.pm
          feature: added rfmode, register rubric & comments
          change: fix perlcritic Severity 3 - hard tabs
          feature: Added crc checksum verification Revolt (#956)

  14_SD_WS.pm: 
         feature: protocol 27 for sensor EFS-3110A (#890)
         feature: protocol 106 for GT-TMBBQ-0   
         feature: protocol 110 for ADE WS1907 Weather station (#970)
         feature: protocol 111 for TS-FT002 water tank level (#1000)
         feature: protocol 113 for GFGT 433 B1 Wireless Grill sensor (#1003)
         feature: new protocol 108 for BRESSER 5-in-1 Weather Center
                  and BRESSER Professional Rain Gauge (#973)
         feature: protocol 115 for Bresser 6-in-1 and 
                  5-in-1 Comfort Wetter Center (#1010)
         feature: new protocol 107 for Fine Offset WH51 (#1055)
         feature: new protocol 116 for Fine Offset WH57 (#1061)
         bugfix: Update protocol 64 for sensor WH2A (#1009)
         bugfix: Conrad S522 protocol 33 no reading batteryState (#1042)

  14_SD_WS07.pm: 
         feature: protocol definition 7.1 for Mebus HQ7312-2 (#1050)

  14_FLAMINGO.pm: 
         change: Perlcritic (#887)

  14_SD_UT.pm:
         change: PerlCritic (#877)
         feature: new protocol 105 for remote control BF-301
         feature: decode and send protocol 56 remote control AC114-01B (#910)
         feature: decode and send protocol for Visivo remote control
         feature: Remote control SEAV BeSmart S4 (#933)
         feature: new protocol 114 for TR401 (#1002)

 14_SD_BELL.pm:
         change: PerlCritic (#877)
         change: Adjusted little things (#937)
         feature: added AVANTEK Wireless doorbell & LED night light (#981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protokoll für Bresser 5CH Temp Hygro
3 participants