Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 14_SD_UT.pm - PerlCritic #877

Merged
merged 15 commits into from
Jul 23, 2020
Merged

Update 14_SD_UT.pm - PerlCritic #877

merged 15 commits into from
Jul 23, 2020

Conversation

HomeAutoUser
Copy link
Contributor

@HomeAutoUser HomeAutoUser commented Jul 22, 2020 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

    • ( feature )

  • What is the current behavior? (You can also link to an open issue here)

    • many perl critic messages

  • What is the new behavior (if this is a feature change)?

    • revised for perl critic

Other Information:

  • NO code change, only replaced TABs and critic points

@coveralls
Copy link

coveralls commented Jul 22, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 3626

  • 411 of 766 (53.66%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 53.399%
Changes Missing Coverage Covered Lines Changed/Added Lines %
FHEM/14_SD_UT.pm 411 766 53.66%
Totals Coverage Status
Change from base Build 3624: 0.02%
Covered Lines: 3323
Relevant Lines: 6223
💛 - Coveralls

HomeAutoUser and others added 2 commits July 22, 2020 21:57
@HomeAutoUser
Update 14_SD_UT.pm
48bd945 
  * return to old syntax ( new systax bring 'Too many arguments for main:: ...'  unclear mistakes )
@actions-user
Automatic updated controls and CHANGED
812da7a
@sidey79
Copy link
Contributor

sidey79 commented Jul 22, 2020

Wurde auch Code geändert oder nur Einrückung?

sidey79
sidey79 reviewed Jul 22, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
sidey79
sidey79 reviewed Jul 22, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
@HomeAutoUser
Copy link
Contributor Author

Code wurde nicht geändert.
Nur PerlCritic Dinge weil du dies gerne haben möchtest ;)

sidey79
sidey79 reviewed Jul 23, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
sidey79
sidey79 reviewed Jul 23, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
sidey79
sidey79 reviewed Jul 23, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
sidey79
sidey79 reviewed Jul 23, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
sidey79
sidey79 reviewed Jul 23, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
sidey79
sidey79 reviewed Jul 23, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
sidey79
sidey79 reviewed Jul 23, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
sidey79
sidey79 reviewed Jul 23, 2020
View reviewed changes
FHEM/14_SD_UT.pm Outdated Show resolved Hide resolved
@sidey79
Copy link
Contributor

sidey79 commented Jul 23, 2020

Mir ist unverständlich, wieso der Test gegen SD_UT erfolgreich war.
Hätte er nicht sein dürfen aus meiner Sicht. Seltsam.

@HomeAutoUser
Copy link
Contributor Author

You’re not authorized to merge this pull request.
Bitte klicke du :-)

@sidey79 sidey79 merged commit 4b97322 into RFD-FHEM:master Jul 23, 2020
@HomeAutoUser HomeAutoUser deleted the master_SD_UT_perlcritic branch July 23, 2020 22:10
@HomeAutoUser HomeAutoUser added the Perl::Critic code revisions label Jul 25, 2020
@sidey79 sidey79 mentioned this pull request Jan 16, 2022
Merged
sidey79 added a commit that referenced this pull request Jan 16, 2022
@sidey79
Version 3.5.2 erzeugen (#1063)
2c28fd1 
Release 3.5.2 
     10_SD_Rojaflex.pm 
          new: Module for rojaflex remote controls

     90_SIGNALduino_un.pm
          changed: fix some PerlCritic hints (#914)
          changed: revised commandref

     00_SIGNALduino.pm:
          feature: xFSK processing
          feature: Added support for directio and none.
          feature: Extension for "get sduino ccreg" (#918)
          feature: parse subs optimized (#926)
          feature: update reading  config when change settings (#948)
          feature: Allow incremental addition of match list entries (#1026)
          change: added N to send SN  xFSK sendCommand
          change: added new sub SIGNALduino_calcRSSI to simplification code
          change: revised Parse_MN and loglevel
          change: revised logoutput text SIGNALduino_Get_Command
          change: rename "get raw" to "get rawmsg" (#925)
          feature: added commandref rfmode & cc1101_reg_user
          feature: added hardware ESP32cc1101, MAPLEMINI_F103CB on attribute
          feature: added new attrib rfmode to changed to xFSK & revised commandref
          feature: added separat sub SIGNALduino_Attr_rfmode
          feature: added set cmd LaCrossePairForSec (for LaCrosse
          bugfix: SIGNALduino_CheckccConfResponse is more robust #1015 (#1031)
          bugfix: fix PERL WARNING (#895) (#972)
          bugfix: get ccreg command caused stacktrace #898
          bugfix: Bugfix define with hostname 901 (#904)
          bugfix: Wrong version assignment fixed
          Bugfix, module runs now without fhemweb instance 
          bugfix: display protocol list (#947)
          bugfix: require 99_Utils only if really needed (#950)
          bugfix: corrected incorrect logoutput (#951)
          bugfix: Fix Multiple send delay (#941)
          bugfix: Fixes high CPU and MEM usage in patternExists (#988)

  SD_Protocols.pm:
          change: moved subs for converting in own package
                  ConvLaCrosse, ConvKoppFreeControl and ConvPCA301
          bugfix: Hideki fix inverted message (#974)

  SD_ProtocolData.pm
          feature: added rfmode, register rubric & comments
          change: fix perlcritic Severity 3 - hard tabs
          feature: Added crc checksum verification Revolt (#956)

  14_SD_WS.pm: 
         feature: protocol 27 for sensor EFS-3110A (#890)
         feature: protocol 106 for GT-TMBBQ-0   
         feature: protocol 110 for ADE WS1907 Weather station (#970)
         feature: protocol 111 for TS-FT002 water tank level (#1000)
         feature: protocol 113 for GFGT 433 B1 Wireless Grill sensor (#1003)
         feature: new protocol 108 for BRESSER 5-in-1 Weather Center
                  and BRESSER Professional Rain Gauge (#973)
         feature: protocol 115 for Bresser 6-in-1 and 
                  5-in-1 Comfort Wetter Center (#1010)
         feature: new protocol 107 for Fine Offset WH51 (#1055)
         feature: new protocol 116 for Fine Offset WH57 (#1061)
         bugfix: Update protocol 64 for sensor WH2A (#1009)
         bugfix: Conrad S522 protocol 33 no reading batteryState (#1042)

  14_SD_WS07.pm: 
         feature: protocol definition 7.1 for Mebus HQ7312-2 (#1050)

  14_FLAMINGO.pm: 
         change: Perlcritic (#887)

  14_SD_UT.pm:
         change: PerlCritic (#877)
         feature: new protocol 105 for remote control BF-301
         feature: decode and send protocol 56 remote control AC114-01B (#910)
         feature: decode and send protocol for Visivo remote control
         feature: Remote control SEAV BeSmart S4 (#933)
         feature: new protocol 114 for TR401 (#1002)

 14_SD_BELL.pm:
         change: PerlCritic (#877)
         change: Adjusted little things (#937)
         feature: added AVANTEK Wireless doorbell & LED night light (#981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidey79 sidey79 sidey79 approved these changes

Assignees
No one assigned
Labels
Perl::Critic code revisions SD_UT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HomeAutoUser @coveralls @sidey79 @actions-user