Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERL WARNING - Kopp Fix - https://github.com/RFD-FHEM/RFFHEM/issues/968 #972

Merged
merged 4 commits into from
May 26, 2021

Conversation

HomeAutoUser
Copy link
Contributor

@HomeAutoUser HomeAutoUser commented May 25, 2021

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)

2021.05.25 13:21:30.703 4: sduino_dummy: get rawmsg: �MN;D=0A018200CA043A90;R=204;�
2021.05.25 13:21:30.708 4: sduino_dummy: Parse_MN, 2-FSK Protocol id 100 Lacrosse mode 1 msg 0A018200CA043A90 not match (?^:^9)
2021.05.25 13:21:30.713 4: sduino_dummy: Parse_MN, Error! id 101 msg=0A018200CA043A90, message is to short
2021.05.25 13:21:30.717 4: sduino_dummy: Parse_MN, Found GFSK Protocol id 102 -> KoppFreeControl with match (?^:^0)
2021.05.25 13:21:30.721 4: sduino_dummy: Parse_MN, Error! method ConvKoppFreeControl, hexData is to short
2021.05.25 13:21:30.725 4: sduino_dummy: Parse_MN, 2-FSK Protocol id 103 Lacrosse mode 2 msg 0A018200CA043A90 not match (?^:^9)
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #972 (c636255) into master (2c4ac54) will increase coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
+ Coverage   58.33%   58.37%   +0.03%     
==========================================
  Files         106      106              
  Lines        8478     8485       +7     
  Branches     1323     1323              
==========================================
+ Hits         4946     4953       +7     
  Misses       2638     2638              
  Partials      894      894              
Flag Coverage Δ
fhem 48.56% <0.00%> (ø)
modules 58.37% <88.88%> (+0.03%) ⬆️
perl 91.54% <88.88%> (+0.02%) ⬆️
unittests 58.37% <88.88%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_Protocols.pm 79.01% <0.00%> (ø)
t/SD_Protocols/02_ConvKoppFreeControl.t 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4ac54...c636255. Read the comment docs.

added test with to short data
@sidey79
Copy link
Contributor

sidey79 commented May 26, 2021

Ich habe den Test ergänzt

Anzahl geplanter tests korrigiert
@HomeAutoUser HomeAutoUser merged commit 5e0ef69 into RFD-FHEM:master May 26, 2021
@HomeAutoUser
Copy link
Contributor Author

@sidey79 Danke :-)

@HomeAutoUser HomeAutoUser deleted the master_Kopp_Fix branch May 26, 2021 19:30
sidey79 added a commit that referenced this pull request Jan 16, 2022
Release 3.5.2 
     10_SD_Rojaflex.pm 
          new: Module for rojaflex remote controls

     90_SIGNALduino_un.pm
          changed: fix some PerlCritic hints (#914)
          changed: revised commandref

     00_SIGNALduino.pm:
          feature: xFSK processing
          feature: Added support for directio and none.
          feature: Extension for "get sduino ccreg" (#918)
          feature: parse subs optimized (#926)
          feature: update reading  config when change settings (#948)
          feature: Allow incremental addition of match list entries (#1026)
          change: added N to send SN  xFSK sendCommand
          change: added new sub SIGNALduino_calcRSSI to simplification code
          change: revised Parse_MN and loglevel
          change: revised logoutput text SIGNALduino_Get_Command
          change: rename "get raw" to "get rawmsg" (#925)
          feature: added commandref rfmode & cc1101_reg_user
          feature: added hardware ESP32cc1101, MAPLEMINI_F103CB on attribute
          feature: added new attrib rfmode to changed to xFSK & revised commandref
          feature: added separat sub SIGNALduino_Attr_rfmode
          feature: added set cmd LaCrossePairForSec (for LaCrosse
          bugfix: SIGNALduino_CheckccConfResponse is more robust #1015 (#1031)
          bugfix: fix PERL WARNING (#895) (#972)
          bugfix: get ccreg command caused stacktrace #898
          bugfix: Bugfix define with hostname 901 (#904)
          bugfix: Wrong version assignment fixed
          Bugfix, module runs now without fhemweb instance 
          bugfix: display protocol list (#947)
          bugfix: require 99_Utils only if really needed (#950)
          bugfix: corrected incorrect logoutput (#951)
          bugfix: Fix Multiple send delay (#941)
          bugfix: Fixes high CPU and MEM usage in patternExists (#988)

  SD_Protocols.pm:
          change: moved subs for converting in own package
                  ConvLaCrosse, ConvKoppFreeControl and ConvPCA301
          bugfix: Hideki fix inverted message (#974)

  SD_ProtocolData.pm
          feature: added rfmode, register rubric & comments
          change: fix perlcritic Severity 3 - hard tabs
          feature: Added crc checksum verification Revolt (#956)

  14_SD_WS.pm: 
         feature: protocol 27 for sensor EFS-3110A (#890)
         feature: protocol 106 for GT-TMBBQ-0   
         feature: protocol 110 for ADE WS1907 Weather station (#970)
         feature: protocol 111 for TS-FT002 water tank level (#1000)
         feature: protocol 113 for GFGT 433 B1 Wireless Grill sensor (#1003)
         feature: new protocol 108 for BRESSER 5-in-1 Weather Center
                  and BRESSER Professional Rain Gauge (#973)
         feature: protocol 115 for Bresser 6-in-1 and 
                  5-in-1 Comfort Wetter Center (#1010)
         feature: new protocol 107 for Fine Offset WH51 (#1055)
         feature: new protocol 116 for Fine Offset WH57 (#1061)
         bugfix: Update protocol 64 for sensor WH2A (#1009)
         bugfix: Conrad S522 protocol 33 no reading batteryState (#1042)

  14_SD_WS07.pm: 
         feature: protocol definition 7.1 for Mebus HQ7312-2 (#1050)

  14_FLAMINGO.pm: 
         change: Perlcritic (#887)

  14_SD_UT.pm:
         change: PerlCritic (#877)
         feature: new protocol 105 for remote control BF-301
         feature: decode and send protocol 56 remote control AC114-01B (#910)
         feature: decode and send protocol for Visivo remote control
         feature: Remote control SEAV BeSmart S4 (#933)
         feature: new protocol 114 for TR401 (#1002)

 14_SD_BELL.pm:
         change: PerlCritic (#877)
         change: Adjusted little things (#937)
         feature: added AVANTEK Wireless doorbell & LED night light (#981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3.5.1+20210505 - PERL WARNING: Use of uninitialized value in hex at FHEM/lib/SD_Protocols.pm line 1821.
3 participants