update reading config when change settings #948

elektron-bbs · 2021-02-27T13:27:57Z

Please check if the PR fulfills these requirements

Tests for the changes have been added / modified (needed for for bug fixes / features)
commandref has been added / updated (needed for bug fixes / features)
CHANGED has been updated (needed for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
no update of reading config when change settings
What is the new behavior (if this is a feature change)?
Automatic update of the reading config with set enable/disable MessageType or set raw CER/CDR.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information:

Automatic update of the reading config with set enable/disable MessageType or set raw CER/CDR.

codecov · 2021-02-27T13:28:04Z

Codecov Report

Merging #948 (9bebdbe) into master (9a896fd) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master     #948   +/-   ##
=======================================
  Coverage   58.11%   58.11%           
=======================================
  Files         105      105           
  Lines        8406     8409    +3     
  Branches     1313     1314    +1     
=======================================
+ Hits         4885     4887    +2     
  Misses       2637     2637           
- Partials      884      885    +1

Flag	Coverage Δ
fhem	`48.39% <75.00%> (+<0.01%)`	⬆️
modules	`58.11% <75.00%> (+<0.01%)`	⬆️
perl	`91.42% <ø> (ø)`
unittests	`58.11% <75.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
t/FHEM/00_SIGNALduino/03_SIGNALduino_Set.t	`100.00% <ø> (ø)`
FHEM/00_SIGNALduino.pm	`61.94% <75.00%> (+<0.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a896fd...9bebdbe. Read the comment docs.

FHEM/00_SIGNALduino.pm

Update Commandref

sidey79 · 2021-02-28T19:44:22Z

CHANGED


-* Display protocol list


Den Text hast Du bestimmt nicht absichtlich entfernt oder?

Doch sicher, wahrscheinlich war er doppelt drin. Aktuell sieht es so aus:

2021-02-27 - Master bugfix protocol list (#947) * Display protocol list Msg type MC is not displayed in the protocol list * Added test for SIGNALduino_FW_getProtocolList to check if MS, MC, MU, MN Tag is included Co-authored-by: sidey79 <7968127+sidey79@users.noreply.github.com>

sidey79 · 2021-02-28T21:10:28Z

@elektron-bbs
So ich hab noch einen Test für CDR und CER erweitert. Sollte so passen denke ich. Wenn die durch sind gebe ich den PR frei

Release 3.5.2 10_SD_Rojaflex.pm new: Module for rojaflex remote controls 90_SIGNALduino_un.pm changed: fix some PerlCritic hints (#914) changed: revised commandref 00_SIGNALduino.pm: feature: xFSK processing feature: Added support for directio and none. feature: Extension for "get sduino ccreg" (#918) feature: parse subs optimized (#926) feature: update reading config when change settings (#948) feature: Allow incremental addition of match list entries (#1026) change: added N to send SN xFSK sendCommand change: added new sub SIGNALduino_calcRSSI to simplification code change: revised Parse_MN and loglevel change: revised logoutput text SIGNALduino_Get_Command change: rename "get raw" to "get rawmsg" (#925) feature: added commandref rfmode & cc1101_reg_user feature: added hardware ESP32cc1101, MAPLEMINI_F103CB on attribute feature: added new attrib rfmode to changed to xFSK & revised commandref feature: added separat sub SIGNALduino_Attr_rfmode feature: added set cmd LaCrossePairForSec (for LaCrosse bugfix: SIGNALduino_CheckccConfResponse is more robust #1015 (#1031) bugfix: fix PERL WARNING (#895) (#972) bugfix: get ccreg command caused stacktrace #898 bugfix: Bugfix define with hostname 901 (#904) bugfix: Wrong version assignment fixed Bugfix, module runs now without fhemweb instance bugfix: display protocol list (#947) bugfix: require 99_Utils only if really needed (#950) bugfix: corrected incorrect logoutput (#951) bugfix: Fix Multiple send delay (#941) bugfix: Fixes high CPU and MEM usage in patternExists (#988) SD_Protocols.pm: change: moved subs for converting in own package ConvLaCrosse, ConvKoppFreeControl and ConvPCA301 bugfix: Hideki fix inverted message (#974) SD_ProtocolData.pm feature: added rfmode, register rubric & comments change: fix perlcritic Severity 3 - hard tabs feature: Added crc checksum verification Revolt (#956) 14_SD_WS.pm: feature: protocol 27 for sensor EFS-3110A (#890) feature: protocol 106 for GT-TMBBQ-0 feature: protocol 110 for ADE WS1907 Weather station (#970) feature: protocol 111 for TS-FT002 water tank level (#1000) feature: protocol 113 for GFGT 433 B1 Wireless Grill sensor (#1003) feature: new protocol 108 for BRESSER 5-in-1 Weather Center and BRESSER Professional Rain Gauge (#973) feature: protocol 115 for Bresser 6-in-1 and 5-in-1 Comfort Wetter Center (#1010) feature: new protocol 107 for Fine Offset WH51 (#1055) feature: new protocol 116 for Fine Offset WH57 (#1061) bugfix: Update protocol 64 for sensor WH2A (#1009) bugfix: Conrad S522 protocol 33 no reading batteryState (#1042) 14_SD_WS07.pm: feature: protocol definition 7.1 for Mebus HQ7312-2 (#1050) 14_FLAMINGO.pm: change: Perlcritic (#887) 14_SD_UT.pm: change: PerlCritic (#877) feature: new protocol 105 for remote control BF-301 feature: decode and send protocol 56 remote control AC114-01B (#910) feature: decode and send protocol for Visivo remote control feature: Remote control SEAV BeSmart S4 (#933) feature: new protocol 114 for TR401 (#1002) 14_SD_BELL.pm: change: PerlCritic (#877) change: Adjusted little things (#937) feature: added AVANTEK Wireless doorbell & LED night light (#981)

elektron-bbs and others added 3 commits February 27, 2021 14:19

Automatic update of the reading config

9d9db18

Automatic update of the reading config with set enable/disable MessageType or set raw CER/CDR.

Automatic updated controls and CHANGED

6af913c

Update CHANGED

0215c19

elektron-bbs requested a review from sidey79 February 27, 2021 13:36

sidey79 reviewed Feb 27, 2021

View reviewed changes

FHEM/00_SIGNALduino.pm Show resolved Hide resolved

elektron-bbs and others added 4 commits February 28, 2021 11:07

Merge branch 'master' into master_feature_update-config

18ef368

Automatic updated controls and CHANGED

fa77d42

Update 00_SIGNALduino.pm

b962842

Update Commandref

Automatic updated controls and CHANGED

eabb8f8

sidey79 reviewed Feb 28, 2021

View reviewed changes

sidey79 added 2 commits February 28, 2021 21:55

Added Test for raw command CDR and CDE

990c44f

Updated CHANGED

9bebdbe

sidey79 approved these changes Feb 28, 2021

View reviewed changes

elektron-bbs merged commit 2b634ad into master Mar 1, 2021

elektron-bbs deleted the master_feature_update-config branch May 1, 2021 10:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update reading config when change settings #948

update reading config when change settings #948

elektron-bbs commented Feb 27, 2021 •

edited by sidey79

Loading

codecov bot commented Feb 27, 2021 •

edited

Loading

sidey79 Feb 28, 2021

elektron-bbs Feb 28, 2021

sidey79 commented Feb 28, 2021

update reading config when change settings #948

update reading config when change settings #948

Conversation

elektron-bbs commented Feb 27, 2021 • edited by sidey79 Loading

codecov bot commented Feb 27, 2021 • edited Loading

Codecov Report

sidey79 Feb 28, 2021

Choose a reason for hiding this comment

elektron-bbs Feb 28, 2021

Choose a reason for hiding this comment

sidey79 commented Feb 28, 2021

elektron-bbs commented Feb 27, 2021 •

edited by sidey79

Loading

codecov bot commented Feb 27, 2021 •

edited

Loading