Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master - fix PERL WARNING #895

Merged
merged 4 commits into from
Sep 28, 2020
Merged

Conversation

HomeAutoUser
Copy link
Contributor

@HomeAutoUser HomeAutoUser commented Sep 27, 2020

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)

2020.09.27 21:28:48 1: PERL WARNING: Use of uninitialized value in split at ./FHEM/00_SIGNALduino.pm line 676.
2020.09.27 21:28:48 1: stacktrace:
2020.09.27 21:28:48 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (676)
2020.09.27 21:28:48 1:     main::SIGNALduino_Set_flash         called by ./FHEM/00_SIGNALduino.pm (622)
2020.09.27 21:28:48 1:     main::SIGNALduino_Set               called by fhem.pl (3812)
2020.09.27 21:28:48 1:     main::CallFn                        called by fhem.pl (1923)
2020.09.27 21:28:48 1:     main::DoSet                         called by fhem.pl (1955)
2020.09.27 21:28:48 1:     main::CommandSet                    called by fhem.pl (1255)
2020.09.27 21:28:48 1:     main::AnalyzeCommand                called by ./FHEM/01_FHEMWEB.pm (2715)
2020.09.27 21:28:48 1:     main::FW_fC                         called by ./FHEM/01_FHEMWEB.pm (984)
2020.09.27 21:28:48 1:     main::FW_answerCall                 called by ./FHEM/01_FHEMWEB.pm (592)
2020.09.27 21:28:48 1:     main::FW_Read                       called by fhem.pl (3817)
2020.09.27 21:28:48 1:     main::CallFn                        called by fhem.pl (763)
  • What is the new behavior (if this is a feature change)?
    no PERL WARNING

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

  • to generate this error
  1. restart FHEM
  2. set receivername flash ./FHEM/firmware/firmwarefile.hex
  3. look at logfile

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #895 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   54.21%   54.21%           
=======================================
  Files          60       60           
  Lines        7908     7908           
  Branches     1271     1271           
=======================================
  Hits         4287     4287           
  Misses       2829     2829           
  Partials      792      792           
Flag Coverage Δ
#fhem 91.37% <ø> (ø)
#modules 91.37% <ø> (ø)
#perl 91.37% <ø> (ø)
#unittest 54.21% <0.00%> (ø)
#unittests 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 60.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd980a...63e28e4. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 27, 2020

Pull Request Test Coverage Report for Build 3800

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.749%

Totals Coverage Status
Change from base Build 3798: 0.0%
Covered Lines: 3520
Relevant Lines: 6549

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3792

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 53.749%

Totals Coverage Status
Change from base Build 3777: 0.05%
Covered Lines: 3520
Relevant Lines: 6549

💛 - Coveralls

sidey79
sidey79 previously approved these changes Sep 27, 2020
@HomeAutoUser
Copy link
Contributor Author

@sidey79 hier musst du bitte leider den Knopf drücken weil aufgrund der anderen nicht bestandenen Checks dies für mich nicht gestattet ist.

@HomeAutoUser
Copy link
Contributor Author

@sidey79, ich habe die Konflikte behoben und nun wärest du erneut gefragt zum "klick" :-)

@sidey79 sidey79 merged commit 9ea1255 into RFD-FHEM:master Sep 28, 2020
@HomeAutoUser HomeAutoUser deleted the master_fix_PW branch September 29, 2020 20:40
sidey79 added a commit that referenced this pull request Jan 16, 2022
Release 3.5.2 
     10_SD_Rojaflex.pm 
          new: Module for rojaflex remote controls

     90_SIGNALduino_un.pm
          changed: fix some PerlCritic hints (#914)
          changed: revised commandref

     00_SIGNALduino.pm:
          feature: xFSK processing
          feature: Added support for directio and none.
          feature: Extension for "get sduino ccreg" (#918)
          feature: parse subs optimized (#926)
          feature: update reading  config when change settings (#948)
          feature: Allow incremental addition of match list entries (#1026)
          change: added N to send SN  xFSK sendCommand
          change: added new sub SIGNALduino_calcRSSI to simplification code
          change: revised Parse_MN and loglevel
          change: revised logoutput text SIGNALduino_Get_Command
          change: rename "get raw" to "get rawmsg" (#925)
          feature: added commandref rfmode & cc1101_reg_user
          feature: added hardware ESP32cc1101, MAPLEMINI_F103CB on attribute
          feature: added new attrib rfmode to changed to xFSK & revised commandref
          feature: added separat sub SIGNALduino_Attr_rfmode
          feature: added set cmd LaCrossePairForSec (for LaCrosse
          bugfix: SIGNALduino_CheckccConfResponse is more robust #1015 (#1031)
          bugfix: fix PERL WARNING (#895) (#972)
          bugfix: get ccreg command caused stacktrace #898
          bugfix: Bugfix define with hostname 901 (#904)
          bugfix: Wrong version assignment fixed
          Bugfix, module runs now without fhemweb instance 
          bugfix: display protocol list (#947)
          bugfix: require 99_Utils only if really needed (#950)
          bugfix: corrected incorrect logoutput (#951)
          bugfix: Fix Multiple send delay (#941)
          bugfix: Fixes high CPU and MEM usage in patternExists (#988)

  SD_Protocols.pm:
          change: moved subs for converting in own package
                  ConvLaCrosse, ConvKoppFreeControl and ConvPCA301
          bugfix: Hideki fix inverted message (#974)

  SD_ProtocolData.pm
          feature: added rfmode, register rubric & comments
          change: fix perlcritic Severity 3 - hard tabs
          feature: Added crc checksum verification Revolt (#956)

  14_SD_WS.pm: 
         feature: protocol 27 for sensor EFS-3110A (#890)
         feature: protocol 106 for GT-TMBBQ-0   
         feature: protocol 110 for ADE WS1907 Weather station (#970)
         feature: protocol 111 for TS-FT002 water tank level (#1000)
         feature: protocol 113 for GFGT 433 B1 Wireless Grill sensor (#1003)
         feature: new protocol 108 for BRESSER 5-in-1 Weather Center
                  and BRESSER Professional Rain Gauge (#973)
         feature: protocol 115 for Bresser 6-in-1 and 
                  5-in-1 Comfort Wetter Center (#1010)
         feature: new protocol 107 for Fine Offset WH51 (#1055)
         feature: new protocol 116 for Fine Offset WH57 (#1061)
         bugfix: Update protocol 64 for sensor WH2A (#1009)
         bugfix: Conrad S522 protocol 33 no reading batteryState (#1042)

  14_SD_WS07.pm: 
         feature: protocol definition 7.1 for Mebus HQ7312-2 (#1050)

  14_FLAMINGO.pm: 
         change: Perlcritic (#887)

  14_SD_UT.pm:
         change: PerlCritic (#877)
         feature: new protocol 105 for remote control BF-301
         feature: decode and send protocol 56 remote control AC114-01B (#910)
         feature: decode and send protocol for Visivo remote control
         feature: Remote control SEAV BeSmart S4 (#933)
         feature: new protocol 114 for TR401 (#1002)

 14_SD_BELL.pm:
         change: PerlCritic (#877)
         change: Adjusted little things (#937)
         feature: added AVANTEK Wireless doorbell & LED night light (#981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants