use {pacta.portfolio.utils} #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
very excited for this. |
|
Docker image from this PR created |
|
Docker image from this PR created |
jdhoffa
reviewed
May 3, 2023
| uses: actions/checkout@v3 | ||
| with: | ||
| repository: RMI-PACTA/pacta.portfolio.utils | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
Member
There was a problem hiding this comment.
Does this need a token? Isn't the repo public?
Member
Author
There was a problem hiding this comment.
will re-visit this later
|
Docker image from this PR created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted all the utility functions that are used across web tool scripts 1-3 into a separate package. I think this will...
The most interesting/dramatic effect here is that web tool script 3 no longer needs pacta.portfolio.analysis because pacta.portfolio.utils has all the utility functions it needs. (Likewise, eventually web tool script 1 will need pacta.portfolio.audit and not pacta.portfolio.analysis).
Once this is merged, we should remove all the utility functions from pacta.portfolio.analysis. If we do things in this order, we avoid breaking anything temporarily. https://github.com/RMI-PACTA/pacta.portfolio.analysis/issues/242