Skip to content

Conversation

@ipanfilo
Copy link
Collaborator

@ipanfilo ipanfilo commented Apr 26, 2025

Description

Add necessary changes for running TE on gfx950 on NPI image

Fixes # [TE] OCP fp8 bring-up on gfx950 #11918

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • CMake update not to build with AOTriton on unsupported platform
  • Update numerical tolerance in tests to match gfx950
  • Increase GEMM WS size in tests
  • Add test filtering to CTests CI script
  • Avoid unnecessary assigning in HIP FP8 data type wrapper
  • Update max FA version to 2.7.4.post1

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ipanfilo ipanfilo requested a review from wenchenvincent April 29, 2025 21:08
@wenchenvincent wenchenvincent merged commit f602b36 into dev May 1, 2025
6 checks passed
@ipanfilo ipanfilo deleted the ipanfilo/gfx950_bringup branch May 1, 2025 14:26
sarthak-amd pushed a commit that referenced this pull request May 12, 2025
* Gfx950 bringup changes

* Fix pre-ROCm6.3 build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants