Skip to content

Conversation

@VeeraRajasekhar
Copy link
Contributor

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ipanfilo
Copy link
Collaborator

The fix is understood bu can you clarify how the problem manifest itself. And it seems escaped GEMM autotune test so the latter may need improve

@VeeraRajasekhar
Copy link
Contributor Author

The fix is understood bu can you clarify how the problem manifest itself. And it seems escaped GEMM autotune test so the latter may need improve

While I was working on the adding gelu aux, I tested locally with the correct order, while pushing I had a code cleanup then the line was misplaced.

@VeeraRajasekhar VeeraRajasekhar force-pushed the fix_test_gemm_auto_tune branch from 1e06ff2 to 790963c Compare October 31, 2025 15:41
@VeeraRajasekhar VeeraRajasekhar merged commit 72ec76b into dev Oct 31, 2025
ipanfilo pushed a commit that referenced this pull request Nov 8, 2025
@wenchenvincent wenchenvincent deleted the fix_test_gemm_auto_tune branch November 14, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants