Skip to content

Conversation

@ipanfilo
Copy link
Collaborator

Description

Use ROCm .info/version file for ROCm detection when composing build_info instead of HIP package version so the same method is used everywhere

SWDEV-564847

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Change ROCm version detection in common/CMakeLists.txt

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ipanfilo ipanfilo merged commit e9c7361 into dev Nov 12, 2025
1 of 6 checks passed
@ipanfilo ipanfilo deleted the ipanfilo/cmake_rocm_ver branch November 12, 2025 22:40
ipanfilo added a commit that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants