[release/1.6.0] Do not use warpSize as a constexpr in nhwc_batch_norm_kernel.h #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ROCm 7.0, the warpSize variable is no longer constexpr. This commit replaces the variable use with the correct values based on the architecture we're running on.
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jul 9, 2025
updated Apex commit [release/1.6.0] Do not use warpSize as a constexpr in nhwc_batch_norm_kernel.h - ROCm/apex#231 Fixes: https://ontrack-internal.amd.com/browse/SWDEV-541770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ROCm 7.0, the warpSize variable is no longer constexpr. This commit replaces the variable use with the correct values based on the architecture we're running on.
Fixes : https://ontrack-internal.amd.com/browse/SWDEV-541770
Tested with Docker :
registry-sc-harbor.amd.com/framework/compute-rocm-dkms-no-npi-hipclang:16381_ubuntu24.04_py3.12_pytorch_lw_release-2.6_803962f1Updated
/opt/rocm-7.0.0/include/rocrand/rocrand_mtgp32.hwith the changes in the PR https://github.com/ROCm/rocm-libraries/pull/507/filesChecked the following UTs, and these pass: