Fix test_gelu unit test #269
Merged
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the test_gelu pass
Collaborator
Author
|
! cherry-pick --onto release/1.8.0 |
okakarpa
pushed a commit
that referenced
this pull request
Jul 28, 2025
…e the test_gelu pass (#269)
Collaborator
|
Created branch autogenerated/release/1.8.0_cherry-pick_pr-269 and #270 |
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Aug 12, 2025
Commit Messages: - update the param_id calculation so that it works on both CPX and SPX modes (#271) (#272) - reset parameters for FusedDenseGeluDense similar to FusedDense to make the test_gelu pass (#269) (#270) PRs: - ROCm/apex#272 - ROCm/apex#269 Fixes: - https://ontrack-internal.amd.com/browse/SWDEV-540029 - https://ontrack-internal.amd.com/browse/SWDEV-548434
tvukovic-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Aug 20, 2025
Commit Messages: - update the param_id calculation so that it works on both CPX and SPX modes (#271) (#272) - reset parameters for FusedDenseGeluDense similar to FusedDense to make the test_gelu pass (#269) (#270) PRs: - ROCm/apex#272 - ROCm/apex#269 Fixes: - https://ontrack-internal.amd.com/browse/SWDEV-540029 - https://ontrack-internal.amd.com/browse/SWDEV-548434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset parameters for FusedDenseGeluDense similar to FusedDense to make the test_gelu pass
Ran the unit tests:
tested with docker
registry-sc-harbor.amd.com/framework/compute-rocm-dkms-no-npi-hipclang:16456_ubuntu22.04_py3.10_pytorch_lw_rocm7.0_internal_testing_3d404259fixes : https://ontrack-internal.amd.com/browse/SWDEV-540029
Cherry-picked to release/1.8.0 branch via #270