Skip to content

Conversation

@rocm-devops
Copy link
Contributor

Associated JIRA ticket number/Github issue number

Fixes https://ontrack-internal.amd.com/browse/SWDEV-516613

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Continuous Integration

What were the changes?

Fixes for OpenCL conformance test failures

Why are these changes needed?

the PR contains following fixes

  1. support '%F' and '%A' conversion specifiers
  2. handle "hh" or "hl" modifier with vector size 16
  3. handle '%%' escapes in format string
  4. Don't print "(null)" when format string is empty.

tested with latest version of CTS locally.

Updated CHANGELOG?

  • Yes
  • No, Does not apply to this PR.

Added/Updated documentation?

  • Yes
  • No, Does not apply to this PR.

Additional Checks

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally.
  • Any dependent changes have been merged.

@rocm-devops
Copy link
Contributor Author

@rocm-devops
Copy link
Contributor Author

gentle ping..

@rocm-devops
Copy link
Contributor Author

Ping..

@amd-hsivasun
Copy link

Merging is blocked cant import to rocm-systems

@rocm-devops
Copy link
Contributor Author

Error importing due to merge conflicts – please reopen the PR on ROCm/rocm-systems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants