merge main into amd-staging #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm planning to modify this file.
Identified with modernize-use-equals-default.
Identified with modernize-use-nullptr.
In C++17, static constexpr members are implicitly inline, so they no longer require an out-of-line definition. Identified with readability-redundant-declaration.
io.mapRequired takes StringRef as the key type. As such, we do not need to create extraneous copies with str().c_str() or str(). Identified with readability-redundant-string-cstr.
When setting RUNTIMES_USE_LIBC=libc we pass -nostdlibinc if the compiler supports it. This causes compilation failures when trying to build libc++ as libc will try and reference kernel headers in its own headers that it now cannot find. Explicitly reference the kernel headers so the compiler can find them. Reviewers: vonosmas, petrhosek, #reviewers-libcxx, michaelrj-google Reviewed By: michaelrj-google Pull Request: llvm#165114
Suggest the initializer_list overload instead. I plan to deprecate the last variadic `.Cases` in a separate PR. For more context, see llvm#163117.
Update VPInstruction constructor to accept VPIRMetadata between the Flags and DebugLoc parameters. This allows metadata to be passed during construction rather than assigned afterward.
Identified with readability-container-contains.
…#166020) Update all uses of variadic `.Cases` to use the initializer list overload instead. I plan to mark variadic `.Cases` as deprecated in a followup PR. For more context, see llvm#163117.
…#165826) Fold BuildVector where all operands are equal to Broadcast of the first operand. This will subsequently make it easier to remove additional buildvectors/broadcasts, e.g. via llvm#165506. PR: llvm#165826
In the case where the property name is value, the generated op def file would have a collision for hash_value.
These ConstantFold* functions are declared in both: - llvm/include/llvm/Analysis/ConstantFolding.h - llvm/include/llvm/IR/ConstantFold.h However, the implementation resides in llvm/lib/IR/ConstantFold.cpp. This patch removes the declarations in Analysis/ConstantFolding.h and moves associated comments to IR/ConstantFold.h.
z1-cciauto
requested review from
fabianmcg and
nicolasvasilache
as code owners
Collaborator
Author
ronlieb
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.