[Flang] Move builtin .mod generation into runtimes #679
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
Meinersbur
force-pushed
the
users/meinersbur/rocm_flang_builtin-mods
branch
from
0f93940 to
a41ffe8
Compare
…ang_builtin-mods_2
…sbur/flang_builtin-mods_2
…sbur/flang_builtin-mods_2
…sbur/flang_builtin-mods_2
For some reason there were to different flags to build the Fortran modules: 1. LIBOMP_FORTRAN_MODULES=ON and CMAKE_Fortran_COMPILER 2. LIBOMP_FORTRAN_MODULES_COMPILER When using the second, LIBOMP_FORTRAN_MODULES would be off. Trying to keep the option available causes build failures by misinterpretation.
…enmp_hoist-module
…sbur/flang_builtin-mods_2
Meinersbur
force-pushed
the
users/meinersbur/rocm_flang_builtin-mods
branch
from
a41ffe8 to
4a8fef3
Compare
llvm#169638 pre-merged into amd-staging