Skip to content

Conversation

@pruthvistony
Copy link
Collaborator

Fixing the wrong cherry-picks by revert few commits

Updated changes

@pruthvistony
Copy link
Collaborator Author

@alugorey ,
Regarding the changes related to macro CUDABLAS_GETRF_BATCHED_ARGTYPES(<T>), better to add this as a separate commit/PR since this change will need to be upstreamed so separate commit can be easily tracked.

@pruthvistony pruthvistony changed the title Rocm6.0 linalg bathed update Correcting the linalg batched cherry-picks Sep 28, 2023
@pruthvistony
Copy link
Collaborator Author

Local build is successfully.
Triggered CI build - http://rocm-ci.amd.com/job/mainline-framework-pytorch-ci/1368/

Copy link

@alugorey alugorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments

@pruthvistony
Copy link
Collaborator Author

Local testing on test_linalg.py is fine on MI200


Ran 748 tests in 496.351s

OK (skipped=58)

Generating XML reports...
Generated XML report: test-reports/python-unittest/pytorch.test.test_linalg/TEST-TestLinalgCUDA-20230928191748.xml

@pruthvistony pruthvistony merged commit c7de9bb into rocm6.0_internal_testing Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants