[release/2.3] skip test_autocast_rnn #1539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnikolaev-amd
requested review from
jithunnair-amd,
pruthvistony and
ramcherukuri
pruthvistony
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was enabled in the upstream pytorch#121539
But failed with "AssertionError: Tensor-likes are not close! Mismatched elements: 30 / 30 (100.0%)"
in release/2.3 and rocm6.3_internal_testing on MI300 and passed on MI210
Pass with AMD_LOG_LEVEL=3 on MI300
Need to dig deeper
Skip TestCuda::test_autocast_rnn as in other releases (https://ontrack-internal.amd.com/browse/SWDEV-468117)
release/2.1
pytorch/test/test_cuda.py
Line 2023 in 073f5dc
release/2.2
pytorch/test/test_cuda.py
Line 2047 in a3208ba