[ROCm6.4_internal_testing] Update CUDAPluggableAllocator.h #1984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for 34a22804e52a055998431cbb4830953ba4a3eb3a commit finished as FAILURE |
…cator. This is impacting Distributed Fused Adam in Rocm/APEX. See PR ROCm/apex#184
amd-sriram
force-pushed
the
fix_nccl_ub_fail_apex_distributed_fused_adam
branch
from
34a2280 to
f12755b
Compare
|
Jenkins build for f12755bad0567dcaf30304e55c7a870af87f9caa commit finished as FAILURE |
amd-sriram
changed the title
|
Jenkins build for f12755bad0567dcaf30304e55c7a870af87f9caa commit finished as FAILURE |
pruthvistony
approved these changes
Mar 24, 2025
akashveramd
pushed a commit
that referenced
this pull request
Apr 1, 2025
Altering the flag to use the correct streamType in CUDAPluggableAllocator class for ROCm gpu. The flag TORCH_HIP_VERSION does not work for ROCm as intended. This flag is replaced with USE_ROCM. This is impacting Distributed Fused Adam in Rocm/APEX when using nccl_ub feature. This has been tested with rocm/apex. See PR ROCm/apex#184 Pull Request resolved: pytorch#150010 Approved by: https://github.com/jeffdaily
jeffdaily
pushed a commit
that referenced
this pull request
Jun 4, 2025
[ROCm] Update CUDAPluggableAllocator.h (#1984) (pytorch#150010) Altering the flag to use the correct streamType in CUDAPluggableAllocator class for ROCm gpu. The flag TORCH_HIP_VERSION does not work for ROCm as intended. This flag is replaced with USE_ROCM. This is impacting Distributed Fused Adam in Rocm/APEX when using nccl_ub feature. This has been tested with rocm/apex. See PR ROCm/apex#184 Pull Request resolved: pytorch#150010 Approved by: https://github.com/jeffdaily (cherry picked from commit a19b667) Co-authored-by: Sriram Kumar <skishore@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altering the flag to use the correct streamType for CUDAPluggableAllocator. This is impacting Distributed Fused Adam in Rocm/APEX.
See PR ROCm/apex#184
Related Issue : https://ontrack-internal.amd.com/browse/SWDEV-519796
To fix the following error when building apex:
2025-03-25T14:19:25.0187731Z #5 1815.5 FAILED: /root/dockerbuild/pytorch.1.7.0a0/apex/build/temp.linux-x86_64-cpython-312/apex/contrib/csrc/nccl_allocator/NCCLAllocator_hip.o