Skip to content

Conversation

@ethanwee1
Copy link

@ethanwee1 ethanwee1 commented May 8, 2025

Removing --no-deps and --no-index flags because the old setuptools was installing the requirements of the torch wheel along with those of the torchvision wheel when using the old setuptools version (<80.0.1) and in versions greater than setuptools 80.0.1, the new setuptools does not install the requirements of the torch wheel and torchvision wheel.

Resolves
https://ontrack-internal.amd.com/browse/SWDEV-531011

Validation:
http://rocm-ci.amd.com/job/framework-pytorch-2.6-ub22-py3.10-ci_rel-6.4-preview/60/

Cherry-picked to release/2.3 branch via #2142

Cherry-picked to release/2.4 branch via #2143

@rocm-repo-management-api
Copy link

Jenkins build for 011d3643a29c07ae8a484c26f662dbaf16b2705f commit is in progress
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

Jenkins build for 011d3643a29c07ae8a484c26f662dbaf16b2705f commit is in progress
Links: Blue Ocean view / Build artifacts

@ethanwee1 ethanwee1 requested a review from jithunnair-amd May 8, 2025 19:30
@ethanwee1 ethanwee1 marked this pull request as ready for review May 8, 2025 19:30
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented May 8, 2025

Jenkins build for 011d3643a29c07ae8a484c26f662dbaf16b2705f commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@jithunnair-amd jithunnair-amd changed the title [release/2.6] Remove no index and no deps flags [release/2.6] Remove --no-index and --no-deps flags May 8, 2025
@jithunnair-amd jithunnair-amd merged commit 5c42a37 into release/2.6 May 8, 2025
1 of 3 checks passed
@jithunnair-amd jithunnair-amd deleted the release2.6_no_deps branch May 8, 2025 20:21
@ethanwee1
Copy link
Author

!cherry-pick --onto rocm6.5_internal_testing

@ethanwee1
Copy link
Author

!cherry-pick --onto rocm6.4_internal_testing

@ethanwee1
Copy link
Author

!cherry-pick --onto release/2.7

@ethanwee1
Copy link
Author

!cherry-pick --onto release/2.5

@ethanwee1
Copy link
Author

!cherry-pick --onto release/2.4

@ethanwee1
Copy link
Author

!cherry-pick --onto release/2.3

okakarpa pushed a commit that referenced this pull request May 12, 2025
Removing --no-deps and --no-index flags because the old setuptools was
installing the requirements of the torch wheel along with those of the
torchvision wheel when using the old setuptools version (<80.0.1) and in
versions greater than setuptools 80.0.1, the new setuptools does not
install the requirements of the torch wheel and torchvision wheel.
Resolves
https://ontrack-internal.amd.com/browse/SWDEV-531011

Validation:

http://rocm-ci.amd.com/job/framework-pytorch-2.6-ub22-py3.10-ci_rel-6.4-preview/60/
@okakarpa
Copy link
Collaborator

@okakarpa
Copy link
Collaborator

Can't perform the cherry-pick keyword: unexpected error

okakarpa pushed a commit that referenced this pull request May 12, 2025
Removing --no-deps and --no-index flags because the old setuptools was
installing the requirements of the torch wheel along with those of the
torchvision wheel when using the old setuptools version (<80.0.1) and in
versions greater than setuptools 80.0.1, the new setuptools does not
install the requirements of the torch wheel and torchvision wheel.
Resolves
https://ontrack-internal.amd.com/browse/SWDEV-531011

Validation:

http://rocm-ci.amd.com/job/framework-pytorch-2.6-ub22-py3.10-ci_rel-6.4-preview/60/
@okakarpa
Copy link
Collaborator

@okakarpa
Copy link
Collaborator

Can't perform the cherry-pick keyword: unexpected error

okakarpa pushed a commit that referenced this pull request May 12, 2025
Removing --no-deps and --no-index flags because the old setuptools was
installing the requirements of the torch wheel along with those of the
torchvision wheel when using the old setuptools version (<80.0.1) and in
versions greater than setuptools 80.0.1, the new setuptools does not
install the requirements of the torch wheel and torchvision wheel.
Resolves
https://ontrack-internal.amd.com/browse/SWDEV-531011

Validation:

http://rocm-ci.amd.com/job/framework-pytorch-2.6-ub22-py3.10-ci_rel-6.4-preview/60/
@okakarpa
Copy link
Collaborator

Created branch autogenerated/release/2.7_cherry-pick_pr-2103 and #2123

@okakarpa
Copy link
Collaborator

Can't perform the cherry-pick keyword: unexpected error

okakarpa pushed a commit that referenced this pull request May 12, 2025
Removing --no-deps and --no-index flags because the old setuptools was
installing the requirements of the torch wheel along with those of the
torchvision wheel when using the old setuptools version (<80.0.1) and in
versions greater than setuptools 80.0.1, the new setuptools does not
install the requirements of the torch wheel and torchvision wheel.
Resolves
https://ontrack-internal.amd.com/browse/SWDEV-531011

Validation:

http://rocm-ci.amd.com/job/framework-pytorch-2.6-ub22-py3.10-ci_rel-6.4-preview/60/
@okakarpa
Copy link
Collaborator

Created branch autogenerated/release/2.4_cherry-pick_pr-2103 and #2136. It contains a merge conflict. Please resolve it

@jithunnair-amd
Copy link
Collaborator

!cherry-pick --onto release/2.4

@okakarpa
Copy link
Collaborator

Created branch autogenerated/release/2.4_cherry-pick_pr-2103 and #2137. It contains a merge conflict. Please resolve it

@jithunnair-amd
Copy link
Collaborator

!cherry-pick --onto release/2.3

@okakarpa
Copy link
Collaborator

Created branch autogenerated/release/2.3_cherry-pick_pr-2103 and #2138. It contains a merge conflict. Please resolve it

@jithunnair-amd
Copy link
Collaborator

!cherry-pick --onto release/2.3

@okakarpa
Copy link
Collaborator

Created branch autogenerated/release/2.3_cherry-pick_pr-2103 and #2139. It contains a merge conflict. Please resolve it

@jithunnair-amd
Copy link
Collaborator

!cherry-pick --onto release/2.3

@okakarpa
Copy link
Collaborator

Created branch autogenerated/release/2.3_cherry-pick_pr-2103 and #2140. It contains a merge conflict. Please resolve it

@jithunnair-amd
Copy link
Collaborator

!cherry-pick --onto release/2.3

@okakarpa
Copy link
Collaborator

Created branch autogenerated/release/2.3_cherry-pick_pr-2103 and #2141. It contains a merge conflict. Please resolve it

@jithunnair-amd
Copy link
Collaborator

!cherry-pick --onto release/2.3 release/2.4

@okakarpa
Copy link
Collaborator

Created branch autogenerated/release/2.3_cherry-pick_pr-2103 and #2142. It contains a merge conflict. Please resolve it

Created branch autogenerated/release/2.4_cherry-pick_pr-2103 and #2143. It contains a merge conflict. Please resolve it

@ethanwee1
Copy link
Author

!cherry-pick --onto rocm6.5_internal_testing

@okakarpa
Copy link
Collaborator

Nothing to cherry-pick onto the rocm6.5_internal_testing branch

pragupta pushed a commit that referenced this pull request Oct 29, 2025
…-deps flags (#2121)

Cherry-pick of #2103

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
(cherry picked from commit 1dea6e8)
pragupta pushed a commit that referenced this pull request Oct 29, 2025
…-deps flags (#2121)

Cherry-pick of #2103

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
(cherry picked from commit 1dea6e8)
pragupta pushed a commit that referenced this pull request Oct 29, 2025
…-deps flags (#2121)

Cherry-pick of #2103

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
(cherry picked from commit 1dea6e8)
pragupta pushed a commit that referenced this pull request Oct 31, 2025
…-deps flags (#2121)

Cherry-pick of #2103

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
(cherry picked from commit 1dea6e8)
jithunnair-amd pushed a commit that referenced this pull request Nov 3, 2025
…-deps flags (#2121)

Cherry-pick of #2103

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
(cherry picked from commit 1dea6e8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants